Skip to content

Ignore interval checks for climatology time axes, and fix interval checks being ingored for time1 axes#972

Merged
mauzey1 merged 3 commits into
mainfrom
943-approx-interval
May 18, 2026
Merged

Ignore interval checks for climatology time axes, and fix interval checks being ingored for time1 axes#972
mauzey1 merged 3 commits into
mainfrom
943-approx-interval

Conversation

@mauzey1
Copy link
Copy Markdown
Collaborator

@mauzey1 mauzey1 commented May 18, 2026

Resolves #943

These changes will allow CMOR to write datasets for climatology variables, specifically for variables that have the "Diurnal Mean" time axis time3. It will allow them by ignoring the time interval check since the diurnal mean time axes will have irregular intervals.

This pull request will also fix a bug where the interval check for time1 axes are ignored when they are not defined with bounds values using cmor_axis.

@mauzey1 mauzey1 requested a review from taylor13 May 18, 2026 18:42
@mauzey1 mauzey1 self-assigned this May 18, 2026
Copy link
Copy Markdown
Collaborator

@taylor13 taylor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (but I didn't check the "test" code). Will we now bypass the check on interval for all climatology axes, or only the time3 axis? Either way is o.k., but I'd like to know.

thanks,
Karl

@mauzey1
Copy link
Copy Markdown
Collaborator Author

mauzey1 commented May 18, 2026

@taylor13 Using cmor_write to pass time values for climatology variables, not just those with time3, will now skip the time interval check just like when passing time values to cmor_axis.

@mauzey1 mauzey1 merged commit 86f012a into main May 18, 2026
21 checks passed
@mauzey1 mauzey1 deleted the 943-approx-interval branch May 18, 2026 23:56
@taylor13
Copy link
Copy Markdown
Collaborator

Great! Thanks.

This was referenced May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

approx_interval

2 participants