Ignore interval checks for climatology time axes, and fix interval checks being ingored for time1 axes#972
Merged
Merged
Conversation
…d skip interval checks for climatology time axes in cmor_write
taylor13
approved these changes
May 18, 2026
Collaborator
taylor13
left a comment
There was a problem hiding this comment.
Looks good (but I didn't check the "test" code). Will we now bypass the check on interval for all climatology axes, or only the time3 axis? Either way is o.k., but I'd like to know.
thanks,
Karl
Collaborator
Author
|
@taylor13 Using |
Collaborator
|
Great! Thanks. |
This was referenced May 20, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #943
These changes will allow CMOR to write datasets for climatology variables, specifically for variables that have the "Diurnal Mean" time axis
time3. It will allow them by ignoring the time interval check since the diurnal mean time axes will have irregular intervals.This pull request will also fix a bug where the interval check for
time1axes are ignored when they are not defined with bounds values usingcmor_axis.