Remove __cpp_lib_filesystem check for <filesystem>#451
Merged
Conversation
This project has long since targetted `c++17`, which includes `<filesystem>` as part of the standard. It has then been updated to target `c++20`. Further the `__cpp_lib_filesystem` macro is defined in `<version>` which is part of the `c++20` standard. That means we'd need to use a `c++20` feature to detect support for a `c++17` feature. Seems kind of pointless.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This project has long since targetted
c++17, which includes<filesystem>as part of the standard. It has then been updated to targetc++20. Further the__cpp_lib_filesystemmacro is defined in<version>which is part of thec++20standard. That means we'd need to use ac++20feature to detect support for ac++17feature. Seems kind of pointless.Closes #450
Related:
__cpp_lib_filesysteminXFile#450