HW done#102
Open
andreiRookie wants to merge 8 commits into
Open
Conversation
antonkazakov
suggested changes
Dec 24, 2023
antonkazakov
left a comment
antonkazakov
left a comment
Contributor
There was a problem hiding this comment.
Привет. Оставил пару комментариев
|
|
||
| @Inject | ||
| lateinit var vmFactory: ViewModelFactory | ||
| private val viewModel: ViewModelReceiver by lazy { |
Contributor
There was a problem hiding this comment.
Не думаю что в lazy тем более потокобезопасном есть смысл
|
|
||
| fun inject(fragment: FragmentReceiver) | ||
|
|
||
| @Component.Factory |
Contributor
There was a problem hiding this comment.
А есть ли тут смысл в фабрике? не кажется когда у тебя параметров не добавляется билдер удобнее, ничего писать не нужно
| } | ||
|
|
||
| companion object { | ||
| private var fragmentReceiverComponent: FragmentReceiverComponent? = null |
Contributor
There was a problem hiding this comment.
Понадобиться где то его инстанс?
| import javax.inject.Qualifier | ||
|
|
||
| @Qualifier | ||
| @Retention(AnnotationRetention.BINARY) |
|
|
||
| class ViewModelReceiver( | ||
| class ViewModelReceiver @Inject constructor( | ||
| private val observer: Channel<LocalEvent>, |
Contributor
There was a problem hiding this comment.
Не очень правильно что ты можешь в приемники эмитить события в Channel, сделай здесь ReceiveChannel, а в другой ВМ SendChannel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.