[elistbox] fix wrap-around logic for selection movement at boundaries - #1300
Closed
DimitarCC wants to merge 2 commits into
Closed
[elistbox] fix wrap-around logic for selection movement at boundaries#1300DimitarCC wants to merge 2 commits into
DimitarCC wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the selection wrap-around logic in the
eListboxcomponent to improve accuracy and user experience when navigating between pages. The conditions for wrapping around at the beginning and end of the list have been refined to trigger only when the selection is at the very first or last entry, rather than at the start or end of a page.Selection wrap-around logic improvements:
eListbox::moveSelection, the wrap-around when moving up (pageUp/prevPage) now only occurs if the selection is at the very first entry, instead of anywhere on the first page.pageDown/nextPage) now only occurs if the selection is at the very last entry, instead of anywhere on the last page.