Add support for MMOItems - #330
Open
vincenzopio wants to merge 6 commits into
Open
Conversation
Contributor
|
@vincenzopio Went through this end to end and it's in good shape. The provider abstraction is clean and leaves room for other item plugins later. A couple of things worth looking at before merge:
|
Contributor
|
One thing I couldn't verify from reading alone is MMOItems display names with color codes go through |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces major enhancements to SmartSpawner's support for custom items, especially MMOItems integration, and improves how item spawners are identified, displayed, and priced. It enables referencing MMOItems in spawner configurations, allows custom pricing for plugin-owned items, and ensures spawner GUIs and holograms show the correct item names and icons. The changes also refactor the price GUI to handle both vanilla and custom items seamlessly.
Custom Item Integration and Identification
mmoitems:TYPE:IDin configuration files. The spawner will use the MMOItem's name, icon, and display item.Custom Pricing and Price GUI
sell_integration.yml, keyed by their reference string (e.g.,"mmoitems:MATERIAL:RUBY": 250.0). These prices override shop-derived prices. The price GUI and backend now handle both vanilla and plugin items, displaying the correct icon and name for each. [1] [2] [3] [4] [5]Display and Hologram Improvements
SpawnerDisplayNameutility. This ensures that item spawner holograms display the proper MMOItem or plugin-owned item name and icon. [1] [2] [3] [4] [5] [6] [7] [8] [9]Integration Infrastructure
mmoitemsandmythicliband implemented an extensibleCustomItemRegistrywith an MMOItems provider, allowing for future plugin integrations. [1] [2] [3] [4] [5] [6]Configuration and Editor Enhancements
These changes provide robust support for custom item plugins, improve user experience with more accurate displays, and allow for granular configuration and pricing of both vanilla and custom items.