Implement operation element-of expression - #1042
Draft
rascmatt wants to merge 2 commits into
Draft
Conversation
- type checking - behavior lowering
rascmatt
force-pushed
the
feature/op-element-of
branch
from
July 19, 2026 13:21
b958e37 to
3a7f5c2
Compare
Contributor
Author
|
As discussed with @AndreasKrall in our weekly meeting today, the |
rascmatt
marked this pull request as draft
August 3, 2026 08:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements type checking and behavior lowering for the element-of (
∈) and no-element-of (∉) binary operators within the[assert : ...]and[stop : ...]annotations of group expressions.Since operation definitions are sets of instructions, the semantics of the element-of operators behaves as expected like the element-of operator of a set. To the left side of the expression we allow a reference to some captured instruction, either bound via an
exist .. thenorforall .. thenexpression index, or via a group reference.Examples:
This is the last remaining piece for the group expression/annotations required for VLIW support, so I re-enabled those in the
hexagon.vadlspec. This required some slight adaptions, to use the logical or/and operators (||,&&) rather than the bitwise operators.