viam: Prototype new traversal - #1037
Draft
flofriday wants to merge 1 commit into
Draft
Conversation
github-actions
Bot
added
enhancement
The new traversal reduces memory footprint from 4.4G to 3.3G on my machine for running vadl check on huge.
flofriday
force-pushed
the
feature/improve-memory-usage-lowering
branch
from
June 25, 2026 10:46
a7f8ec3 to
14ca9e5
Compare
Jozott00
reviewed
Jun 25, 2026
| * @param consumer to add the inputs to. | ||
| */ | ||
| protected void collectInputs(List<Node> collection) { /* nothing to add */ | ||
| protected void forEachInput(Consumer<Node> consumer) { /* nothing to add */ |
Contributor
There was a problem hiding this comment.
Looks like a good approach to reduce memory allocations when no list is required.
Jozott00
reviewed
Jun 25, 2026
Comment on lines
+174
to
+192
| private static class FoundSignal extends RuntimeException { | ||
| @SuppressWarnings("StaticAssignmentOfThrowable") | ||
| static final FoundSignal INSTANCE = new FoundSignal(); | ||
|
|
||
| private FoundSignal() { | ||
| super(null, null, false, false); | ||
| } | ||
| } | ||
|
|
||
| public final boolean containsInput(Node needle) { | ||
| try { | ||
| forEachInput(input -> {if (input.equals(needle)) | ||
| throw FoundSignal.INSTANCE; | ||
| }); | ||
| return false; | ||
| } catch (FoundSignal signal) { | ||
| return true; | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Do we know the runtime performance impact of this approach?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new traversal reduces memory footprint from 4.4G to 3.3G on my machine for running vadl check on huge.
This really is just a prototype to discuss this approach, it's drawbacks etc, the code is far from final!