Delete unreachable assembly and its stale declarations - #71
Merged
ZivDero merged 1 commit intoAug 29, 2026
Merged
Conversation
No documentation update: the deleted code was unreachable, so no documented behavior is affected.
ZivDero
requested changes
Aug 29, 2026
| IsoDrawData.RowRunLength += ISO_DRAW_WIDTH; | ||
| } | ||
| } | ||
| } else if (!IsoTileUseAsmDrawFunc || depth_only || fill || fog) { |
Contributor
Author
There was a problem hiding this comment.
IsoTileUseAsmDrawFunc was always false and the remaining three are checked inside of the else branch so it should be functionally equivalent.
|
Development builds of c9a666d: The links work without a GitHub account. Artifacts expire after 90 days, and this comment follows the latest successful build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove unused assembly code as a first step to cross platform compatibility.
Behavior and compatibility
Behaviour is perserved as is.
Validation
Manual smoke test.
Documentation
No documentation update: the deleted code was unreachable, so no documented behavior is affected.
Checklist