Add in-place SPSS schema transformations - #14
Conversation
|
@codex review |
|
@codex review latest commit |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2c12ba814d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| later_create = any( | ||
| isinstance(later_operation, CreateVariableOperation) | ||
| for later_operation in plan.operations[operation_index + 1:] |
There was a problem hiding this comment.
When a plan starts from a one-variable schema and deletes that variable before creating a numeric replacement, e.g. DELETE VARIABLES only. COMPUTE replacement = 1., the final schema is non-empty and numeric create targets are otherwise supported. This lookahead only treats CreateVariableOperation as a later create, so _bind_delete rejects the delete before a later AssignOperation/RecodeOperation with target_mode="create" can add the replacement. Include those target-creating operations in the lookahead so valid sequential plans are not rejected.
Useful? React with 👍 / 👎.
1 participant
Adds Python parity for core in-place SPSS schema transformations.
STRINGandDELETE VARIABLESexecution with fail-closed range syntax.Validation: focused transformation regression suite passes locally; PostgreSQL service test is skipped locally when no service URL is configured.