Skip to content

chore: adopt OpenStatSpec SPSS codec 3.0.3 #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TonisOrmisson merged 2 commits into from
Aug 3, 2026
Merged

chore: adopt OpenStatSpec SPSS codec 3.0.3 #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6a686c
docs: update SPSS codec references
TonisOrmisson Aug 2, 2026
ff892b5
chore: update SPSS codec to 3.0.3
TonisOrmisson Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions docs/architecture.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,9 +102,9 @@ feature. Dolt owns history and rollback. See the
[transformation manual](transformations.md) for the complete contract and
operational guidance.

## External engine
## SPSS codec

The selected engine is [TonisOrmisson/php-spss](https://github.com/TonisOrmisson/php-spss), Composer dependency `tiamo/spss` 3.x. It is external. If a compatible reader or writer is unavailable, the adapter produces an explicit `external_engine_unavailable` diagnostic rather than pretending conversion succeeded.
The selected engine is [OpenStatSpec/php-spss](https://github.com/OpenStatSpec/php-spss), installed as Composer dependency `openstatspec/spss-sav` 3.x and maintained by OpenStatSpec. It remains a separately versioned package. If a compatible reader or writer is unavailable, the adapter produces an explicit `external_engine_unavailable` diagnostic rather than pretending conversion succeeded.

## Framework boundary

Expand Down
2 changes: 1 addition & 1 deletion src/Spss/PhpSpssEngine.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ final class PhpSpssEngine implements SpssEngine
public const READER_CLASS = 'SPSS\\Sav\\Reader';
public const WRITER_CLASS = 'SPSS\\Sav\\Writer';
public const CLAIMED_VERSION_RANGE = '>=3.0.0 <4.0.0';
public const CI_TESTED_VERSIONS = ['3.0.2'];
public const CI_TESTED_VERSIONS = ['3.0.3'];

public function isAvailable(): bool
{
Expand Down
4 changes: 2 additions & 2 deletions tests/Core/CapabilityDeclarationTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,9 @@ public function testDeclarationIsMachineReadableAndIncludesEveryProfileLimit():
'maximum_source_file_bytes' => null,
'limit_basis' => 'runtime_memory_limit',
], $declaration['resource_behavior']);
self::assertSame('3.0.2', $declaration['engine']['active_version']);
self::assertSame('3.0.3', $declaration['engine']['active_version']);
self::assertSame('>=3.0.0 <4.0.0', $declaration['engine']['claimed_version_range']);
self::assertSame(['3.0.2'], $declaration['engine']['ci_tested_versions']);
self::assertSame(['3.0.3'], $declaration['engine']['ci_tested_versions']);
self::assertTrue($declaration['engine']['claimed_supported']);
self::assertNotEmpty($declaration['required_capabilities']);
foreach ($declaration['required_capabilities'] as $supported) {
Expand Down
2 changes: 1 addition & 1 deletion tests/Integration/OfficialSpssConformanceManifestTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ private function assertRequiredCapabilities(array $manifest, SpssAdapter $adapte
self::assertTrue($declaration['active_connection']['claimed_supported'], $profile . ': active server version is outside the claimed profile');
self::assertSame($declaration['sql_profiles'][$profile]['claimed_server_versions'], $declaration['active_connection']['matched_claim']);
self::assertTrue($declaration['engine']['claimed_supported']);
self::assertSame(['3.0.2'], $declaration['engine']['ci_tested_versions']);
self::assertSame(['3.0.3'], $declaration['engine']['ci_tested_versions']);
self::assertContains($profile, array_keys($declaration['sql_profiles'] ?? []));
self::assertContains('import', $declaration['directions'] ?? []);
self::assertContains('export', $declaration['directions'] ?? []);
Expand Down
6 changes: 3 additions & 3 deletions tests/Spss/SpssAdapterTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,10 @@ public function testComposerInstallsTheOfficialPhpSpssV3Engine(): void
self::assertTrue(class_exists(Dataset::class));
self::assertSame([
'package' => 'openstatspec/spss-sav',
'version' => '3.0.2',
'active_version' => '3.0.2',
'version' => '3.0.3',
'active_version' => '3.0.3',
'claimed_version_range' => '>=3.0.0 <4.0.0',
'ci_tested_versions' => ['3.0.2'],
'ci_tested_versions' => ['3.0.3'],
'claimed_supported' => true,
], (new PhpSpssEngine())->identity());
}
Expand Down