Skip to content

refactor(speakers): Performance update for getUniqueActivitiesCountBySummit query#559

Closed
mulldug wants to merge 1 commit into
mainfrom
perf/speaker-activities-count-query
Closed

refactor(speakers): Performance update for getUniqueActivitiesCountBySummit query#559
mulldug wants to merge 1 commit into
mainfrom
perf/speaker-activities-count-query

Conversation

@mulldug

@mulldug mulldug commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

replace nested IN(SELECT DISTINCT) with correlated EXISTS in getUniqueActivitiesCountBySummit

The previous implementation wrapped the filter subquery output in IN(SELECT DISTINCT speaker_ids), forcing MySQL to materialise the full intermediate set and probe it per outer presentation row.

Restructured as a single correlated EXISTS rooted at PresentationSpeaker: the inner QB checks assignment or moderator membership against the outer presentation p directly, with filter predicates appended inline. MySQL can now use the Presentation_Speakers(PresentationID) index and short-circuit on the first match per row.

Summary by CodeRabbit

  • Refactor
    • Optimized internal query performance for activity counting operations to improve overall system responsiveness.

@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@mulldug, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 44 minutes and 4 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f3648ea6-b590-47ab-9442-9c0db8dc3392

📥 Commits

Reviewing files that changed from the base of the PR and between 39ee189 and a74c002.

📒 Files selected for processing (1)
  • app/Repositories/Summit/DoctrineSpeakerRepository.php
📝 Walkthrough

Walkthrough

DoctrineSpeakerRepository::getUniqueActivitiesCountBySummit is rewritten to replace the previous inner-query-with-IN(...) pattern with a correlated EXISTS subquery. The inner QB selects 1 from PresentationSpeaker, correlates to the outer Presentation p, applies the provided filter, and the outer QB counts COUNT(DISTINCT p.id). Parameter binding changes from summit_id to summit, and non-summit parameters are explicitly copied from the inner QB to the outer QB.

Changes

Correlated EXISTS rewrite for unique activities count

Layer / File(s) Summary
Correlated EXISTS query construction and parameter propagation
app/Repositories/Summit/DoctrineSpeakerRepository.php
Replaces the IN(distinct speaker IDs) subquery with a correlated EXISTS subquery rooted at PresentationSpeaker. The inner QB selects a constant and correlates to the outer Presentation p via speaker assignment or moderator conditions, applies the caller Filter via getFilterMappings, and the outer QB counts COUNT(DISTINCT p.id) with p.summit = :summit AND EXISTS(<innerDql>). Non-summit parameters are explicitly copied from the inner QB to the outer QB before returning the scalar integer.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐇 Hoppity-hop through the query maze,
No longer hunting IDs through IN-filled haze!
EXISTS now peeks, correlated and keen,
The neatest subquery a bunny has seen.
Parameters copied, the summit stands tall—
One slick EXISTS to count them all! 🥕

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title accurately describes the primary change: a performance optimization of the getUniqueActivitiesCountBySummit query through restructuring from nested IN-based to EXISTS-based subqueries.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch perf/speaker-activities-count-query

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

Copy link
Copy Markdown

📘 OpenAPI / Swagger preview

➡️ https://OpenStackweb.github.io/summit-api/openapi/pr-559/

This page is automatically updated on each push to this PR.

@mulldug mulldug changed the title perf(speakers): Performance update for getUniqueActivitiesCountBySummit query refactor(speakers): Performance update for getUniqueActivitiesCountBySummit query Jun 18, 2026
…d EXISTS in getUniqueActivitiesCountBySummit

The previous implementation wrapped the filter subquery output in IN(SELECT DISTINCT speaker_ids), forcing MySQL to materialise the full intermediate set and probe it per outer presentation row.

Restructured as a single correlated EXISTS rooted at PresentationSpeaker: the inner QB checks assignment or moderator membership against the outer presentation p directly, with filter predicates appended inline. MySQL can now use the Presentation_Speakers(PresentationID) index and short-circuit on the first match per row.
@mulldug mulldug force-pushed the perf/speaker-activities-count-query branch from 39ee189 to a74c002 Compare June 18, 2026 16:10
@github-actions

Copy link
Copy Markdown

📘 OpenAPI / Swagger preview

➡️ https://OpenStackweb.github.io/summit-api/openapi/pr-559/

This page is automatically updated on each push to this PR.

@mulldug mulldug closed this Jun 18, 2026
@mulldug mulldug deleted the perf/speaker-activities-count-query branch June 18, 2026 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant