Skip to content

feat: Extend Swagger Coverage for controller OAuth2SummitAttendeesApiController#437

Merged
romanetar merged 12 commits into
mainfrom
feature/openapi-documentation--oauth2summitattendeesapicontroller
Jan 27, 2026
Merged

feat: Extend Swagger Coverage for controller OAuth2SummitAttendeesApiController#437
romanetar merged 12 commits into
mainfrom
feature/openapi-documentation--oauth2summitattendeesapicontroller

Conversation

@matiasperrone-exo

@matiasperrone-exo matiasperrone-exo commented Oct 23, 2025

Copy link
Copy Markdown
Contributor

@matiasperrone-exo matiasperrone-exo self-assigned this Oct 29, 2025
@matiasperrone-exo matiasperrone-exo added the documentation Improvements or additions to documentation label Oct 29, 2025
@matiasperrone-exo matiasperrone-exo added the review Need reviewing from the developer label Nov 10, 2025
@matiasperrone-exo matiasperrone-exo removed the review Need reviewing from the developer label Nov 24, 2025
@matiasperrone-exo matiasperrone-exo force-pushed the feature/openapi-documentation--oauth2summitattendeesapicontroller branch 3 times, most recently from 4500e70 to 567cc68 Compare December 3, 2025 23:02

@caseylocker caseylocker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very close.
namespace App\Swagger\Security; should be namespace App\Swagger\schemas;

Should be good after that.

@matiasperrone-exo matiasperrone-exo force-pushed the feature/openapi-documentation--oauth2summitattendeesapicontroller branch from 567cc68 to d2b2d85 Compare December 4, 2025 17:47
@smarcet

smarcet commented Dec 8, 2025

Copy link
Copy Markdown
Collaborator

@matiasperrone-exo please review conflicts

@caseylocker caseylocker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the updates, once conflicts are cleared this should be good.

@smarcet smarcet force-pushed the main branch 4 times, most recently from c6ecdd0 to 728ae67 Compare December 17, 2025 00:43
@matiasperrone-exo matiasperrone-exo force-pushed the feature/openapi-documentation--oauth2summitattendeesapicontroller branch from 1aef61b to d823c38 Compare December 17, 2025 21:34

@caseylocker caseylocker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the endpoint for:

 #[OA\Post(
        path: '/api/v1/summits/{id}/attendees/all/send',
        ...

Actually uses PUT
Route::put('send', ['middleware' => 'auth.user', 'uses' => 'OAuth2SummitAttendeesApiController@send']);

api_v1.php line 1597
Route::put('send', ...)
ApiEndpointsSeeder.php line 3374:
'http_method' => 'PUT'

Change OA\Post to OA\Put for

#[OA\Post(
        path: '/api/v1/summits/{id}/attendees/all/send',
        operationId: 'sendAttendeesEmail',

@matiasperrone-exo

Copy link
Copy Markdown
Contributor Author

Thanks @caseylocker for the comments. Now is ready to review again

@caseylocker caseylocker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@matiasperrone-exo matiasperrone-exo force-pushed the feature/openapi-documentation--oauth2summitattendeesapicontroller branch from 0da6489 to a57f23d Compare January 20, 2026 21:14
@matiasperrone-exo matiasperrone-exo force-pushed the feature/openapi-documentation--oauth2summitattendeesapicontroller branch from a57f23d to ce7918a Compare January 20, 2026 21:15
@matiasperrone-exo

Copy link
Copy Markdown
Contributor Author

rebased

Signed-off-by: Matias Perrone <github@matiasperrone.com>
Signed-off-by: Matias Perrone <github@matiasperrone.com>
Signed-off-by: Matias Perrone <github@matiasperrone.com>
@matiasperrone-exo matiasperrone-exo force-pushed the feature/openapi-documentation--oauth2summitattendeesapicontroller branch from d44ea3c to 5d507cf Compare January 27, 2026 15:32
Signed-off-by: Matias Perrone <github@matiasperrone.com>
@matiasperrone-exo matiasperrone-exo force-pushed the feature/openapi-documentation--oauth2summitattendeesapicontroller branch from bf4077d to 7de9907 Compare January 27, 2026 15:55
Signed-off-by: Matias Perrone <github@matiasperrone.com>
@romanetar romanetar merged commit 9d7411e into main Jan 27, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants