Feature: upgrade mui v9#249
Open
santipalenque wants to merge 18 commits into
Open
Conversation
📝 WalkthroughWalkthroughThe PR upgrades the library to target MUI 9, React 18/19, and Node 22. Component prop APIs are migrated from deprecated ChangesMUI 9 and React 18 Migration
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
santipalenque
force-pushed
the
feature/upgrade-mui-v9
branch
from
54e6f6e to
b89d534
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@package.json`:
- Around line 145-156: The package.json declares peer ranges for react/react-dom
including ^19.0.0 but depends on react-redux ^7.1.0 which only supports up to
React 18; either (A) narrow react/react-dom peer ranges to ^18.0.0 (update the
"react" and "react-dom" entries) so they match react-redux@7.x, or (B) upgrade
react-redux to a v8+ release that lists support for React 19 and also update the
redux peer range to the version required by that react-redux major (e.g., bump
"react-redux" and adjust "redux" peer range accordingly); pick one approach and
update the package.json entries for "react", "react-dom", "react-redux", and
"redux" consistently and run install to verify no peer conflicts.
In `@src/components/inputs/upload-input-v3/index.js`:
- Around line 388-394: The anchor that opens the preview in a new tab (the <a>
wrapping ProgressiveImg, using props src, previewSrc and title from
T.translate("upload_input_v3.see_preview")) uses target="_blank" but lacks rel
attributes; update that anchor to include rel="noopener noreferrer" to prevent
reverse-tabnabbing when opening external URLs while keeping the existing target
and children intact.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 9a5238b8-62c5-444a-878d-b8d24486e40c
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (27)
package.jsonsrc/components/inputs/company-input-v2.jssrc/components/inputs/upload-input-v3/index.jssrc/components/mui/FormItemTable/__tests__/FormItemTable.test.jssrc/components/mui/__tests__/additional-input-list.test.jssrc/components/mui/__tests__/additional-input.test.jssrc/components/mui/__tests__/meta-field-values.test.jssrc/components/mui/__tests__/mui-formik-datepicker.test.jssrc/components/mui/__tests__/mui-formik-switch.test.jssrc/components/mui/cards/InlineCard/index.jssrc/components/mui/cards/TableCard/index.jssrc/components/mui/formik-inputs/additional-input/additional-input.jssrc/components/mui/formik-inputs/additional-input/meta-field-values.jssrc/components/mui/formik-inputs/company-input-mui.jssrc/components/mui/formik-inputs/item-price-tiers.jssrc/components/mui/formik-inputs/mui-formik-async-select.jssrc/components/mui/formik-inputs/mui-formik-pricefield.jssrc/components/mui/formik-inputs/mui-formik-textfield.jssrc/components/mui/formik-inputs/mui-sponsor-input.jssrc/components/mui/formik-inputs/sponsorship-input-mui.jssrc/components/mui/menu-button.jssrc/components/mui/table/extra-rows/DiscountRow.jsxsrc/components/mui/table/extra-rows/FeeRow.jsxsrc/components/mui/table/extra-rows/PaymentRow.jsxsrc/components/mui/table/extra-rows/RefundRow.jsxsrc/components/mui/table/extra-rows/TotalRow.jsxsrc/utils/methods.js
✅ Files skipped from review due to trivial changes (11)
- src/components/mui/cards/InlineCard/index.js
- src/components/mui/table/extra-rows/DiscountRow.jsx
- src/components/mui/table/extra-rows/PaymentRow.jsx
- src/components/mui/menu-button.js
- src/components/inputs/company-input-v2.js
- src/components/mui/table/extra-rows/RefundRow.jsx
- src/components/mui/cards/TableCard/index.js
- src/components/mui/table/extra-rows/TotalRow.jsx
- src/components/mui/FormItemTable/tests/FormItemTable.test.js
- src/utils/methods.js
- src/components/mui/table/extra-rows/FeeRow.jsx
🚧 Files skipped from review as they are similar to previous changes (12)
- src/components/mui/tests/additional-input-list.test.js
- src/components/mui/tests/mui-formik-datepicker.test.js
- src/components/mui/formik-inputs/mui-formik-textfield.js
- src/components/mui/tests/meta-field-values.test.js
- src/components/mui/formik-inputs/mui-formik-async-select.js
- src/components/mui/formik-inputs/sponsorship-input-mui.js
- src/components/mui/formik-inputs/mui-formik-pricefield.js
- src/components/mui/formik-inputs/mui-sponsor-input.js
- src/components/mui/formik-inputs/item-price-tiers.js
- src/components/mui/formik-inputs/company-input-mui.js
- src/components/mui/tests/additional-input.test.js
- src/components/mui/formik-inputs/additional-input/meta-field-values.js
There was a problem hiding this comment.
Caution
Inline review comments failed to post. This is likely due to GitHub's internal server error or limits when posting large numbers of comments. If you are seeing this consistently it is likely a permissions issue. Please check "Moderation" -> "Code review limits" under your organization settings.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@package.json`:
- Around line 145-156: The package.json declares peer ranges for react/react-dom
including ^19.0.0 but depends on react-redux ^7.1.0 which only supports up to
React 18; either (A) narrow react/react-dom peer ranges to ^18.0.0 (update the
"react" and "react-dom" entries) so they match react-redux@7.x, or (B) upgrade
react-redux to a v8+ release that lists support for React 19 and also update the
redux peer range to the version required by that react-redux major (e.g., bump
"react-redux" and adjust "redux" peer range accordingly); pick one approach and
update the package.json entries for "react", "react-dom", "react-redux", and
"redux" consistently and run install to verify no peer conflicts.
In `@src/components/inputs/upload-input-v3/index.js`:
- Around line 388-394: The anchor that opens the preview in a new tab (the <a>
wrapping ProgressiveImg, using props src, previewSrc and title from
T.translate("upload_input_v3.see_preview")) uses target="_blank" but lacks rel
attributes; update that anchor to include rel="noopener noreferrer" to prevent
reverse-tabnabbing when opening external URLs while keeping the existing target
and children intact.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 9a5238b8-62c5-444a-878d-b8d24486e40c
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (27)
package.jsonsrc/components/inputs/company-input-v2.jssrc/components/inputs/upload-input-v3/index.jssrc/components/mui/FormItemTable/__tests__/FormItemTable.test.jssrc/components/mui/__tests__/additional-input-list.test.jssrc/components/mui/__tests__/additional-input.test.jssrc/components/mui/__tests__/meta-field-values.test.jssrc/components/mui/__tests__/mui-formik-datepicker.test.jssrc/components/mui/__tests__/mui-formik-switch.test.jssrc/components/mui/cards/InlineCard/index.jssrc/components/mui/cards/TableCard/index.jssrc/components/mui/formik-inputs/additional-input/additional-input.jssrc/components/mui/formik-inputs/additional-input/meta-field-values.jssrc/components/mui/formik-inputs/company-input-mui.jssrc/components/mui/formik-inputs/item-price-tiers.jssrc/components/mui/formik-inputs/mui-formik-async-select.jssrc/components/mui/formik-inputs/mui-formik-pricefield.jssrc/components/mui/formik-inputs/mui-formik-textfield.jssrc/components/mui/formik-inputs/mui-sponsor-input.jssrc/components/mui/formik-inputs/sponsorship-input-mui.jssrc/components/mui/menu-button.jssrc/components/mui/table/extra-rows/DiscountRow.jsxsrc/components/mui/table/extra-rows/FeeRow.jsxsrc/components/mui/table/extra-rows/PaymentRow.jsxsrc/components/mui/table/extra-rows/RefundRow.jsxsrc/components/mui/table/extra-rows/TotalRow.jsxsrc/utils/methods.js
✅ Files skipped from review due to trivial changes (11)
- src/components/mui/cards/InlineCard/index.js
- src/components/mui/table/extra-rows/DiscountRow.jsx
- src/components/mui/table/extra-rows/PaymentRow.jsx
- src/components/mui/menu-button.js
- src/components/inputs/company-input-v2.js
- src/components/mui/table/extra-rows/RefundRow.jsx
- src/components/mui/cards/TableCard/index.js
- src/components/mui/table/extra-rows/TotalRow.jsx
- src/components/mui/FormItemTable/tests/FormItemTable.test.js
- src/utils/methods.js
- src/components/mui/table/extra-rows/FeeRow.jsx
🚧 Files skipped from review as they are similar to previous changes (12)
- src/components/mui/tests/additional-input-list.test.js
- src/components/mui/tests/mui-formik-datepicker.test.js
- src/components/mui/formik-inputs/mui-formik-textfield.js
- src/components/mui/tests/meta-field-values.test.js
- src/components/mui/formik-inputs/mui-formik-async-select.js
- src/components/mui/formik-inputs/sponsorship-input-mui.js
- src/components/mui/formik-inputs/mui-formik-pricefield.js
- src/components/mui/formik-inputs/mui-sponsor-input.js
- src/components/mui/formik-inputs/item-price-tiers.js
- src/components/mui/formik-inputs/company-input-mui.js
- src/components/mui/tests/additional-input.test.js
- src/components/mui/formik-inputs/additional-input/meta-field-values.js
🛑 Comments failed to post (2)
package.json (1)
145-156:
⚠️ Potential issue | 🟠 Major🧩 Analysis chain
🏁 Script executed:
#!/bin/bash set -euo pipefail echo "Checking declared peer support for react-redux in the selected range..." # Resolve latest 7.x chosen by ^7.1.0 RR_7_LATEST=$(npm view "react-redux@^7.1.0" version) echo "Resolved react-redux for ^7.1.0 => ${RR_7_LATEST}" echo "Peer deps for react-redux@${RR_7_LATEST}:" npm view "react-redux@${RR_7_LATEST}" peerDependencies --json echo "Peer deps for latest react-redux:" RR_LATEST=$(npm view react-redux version) echo "Latest react-redux => ${RR_LATEST}" npm view "react-redux@${RR_LATEST}" peerDependencies --jsonRepository: OpenStackweb/openstack-uicore-foundation
Length of output: 3177
🏁 Script executed:
#!/bin/bash set -euo pipefail # Resolve the max version in the range ^7.1.0 (i.e., >=7.1.0 and <8.0.0), then print its peer deps. VERS_JSON=$(npm view react-redux versions --json) MAX_VER=$(python3 - <<'PY' import json, re from packaging.version import Version data = json.loads("""__VERS_JSON__""") # data is a list of version strings cands=[] for v in data: # keep only semver-looking versions if not re.match(r'^\d+\.\d+\.\d+.*$', v): continue pv = Version(v.split('-')[0]) # ignore pre-release suffixes for selection if pv >= Version("7.1.0") and pv < Version("8.0.0"): cands.append(pv) if not cands: raise SystemExit("No versions found in range ^7.1.0") print(str(max(cands))) PY ) # substitute JSON into the python snippet safely MAX_VER=$(python3 - <<PY import json, re from packaging.version import Version data = json.loads('''$VERS_JSON''') cands=[] for v in data: if not re.match(r'^\d+\.\d+\.\d+.*$', v): continue pv = Version(v.split('-')[0]) if pv >= Version("7.1.0") and pv < Version("8.0.0"): cands.append(pv) print(str(max(cands))) PY ) echo "Max react-redux version satisfying ^7.1.0 => $MAX_VER" echo echo "peerDependencies for react-redux@$MAX_VER:" npm view "react-redux@$MAX_VER" peerDependencies --json || true echo echo "peerDependencies for react-redux@latest:" npm view react-redux peerDependencies --json || trueRepository: OpenStackweb/openstack-uicore-foundation
Length of output: 684
🏁 Script executed:
#!/bin/bash set -euo pipefail # 1) Inspect the local package.json peer/dev dependency declarations around the referenced lines. echo "---- package.json excerpt (relevant lines) ----" sed -n '70,200p' package.json # 2) Check peerDependencies for a representative/latest react-redux 7.x. echo echo "---- react-redux@7.2.9 peerDependencies ----" npm view react-redux@7.2.9 peerDependencies --json echo echo "---- react-redux@7.1.0 peerDependencies (floor of ^7.1.0) ----" npm view react-redux@7.1.0 peerDependencies --json # 3) Also check react-redux@latest for context. echo echo "---- react-redux@latest peerDependencies ----" npm view react-redux peerDependencies --jsonRepository: OpenStackweb/openstack-uicore-foundation
Length of output: 4867
React peer range claims v19 but
react-redux7.x peers exclude it.
This package declaresreact/react-domsupport for^19.0.0, while the pinnedreact-reduxrange (^7.1.0) resolves to a React-18-only peer contract (e.g.,react-redux@7.2.9peer-depinesreactas^16.8.3 || ^17 || ^18, with no React 19). Either narrow this package’sreact/react-dompeer ranges to React 18, or upgradereact-reduxto a major that supports React 19 (e.g.,react-redux@latestdeclaresreact^18.0 || ^19but also requiresredux^5.0.0, so update thereduxpeer range accordingly).🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@package.json` around lines 145 - 156, The package.json declares peer ranges for react/react-dom including ^19.0.0 but depends on react-redux ^7.1.0 which only supports up to React 18; either (A) narrow react/react-dom peer ranges to ^18.0.0 (update the "react" and "react-dom" entries) so they match react-redux@7.x, or (B) upgrade react-redux to a v8+ release that lists support for React 19 and also update the redux peer range to the version required by that react-redux major (e.g., bump "react-redux" and adjust "redux" peer range accordingly); pick one approach and update the package.json entries for "react", "react-dom", "react-redux", and "redux" consistently and run install to verify no peer conflicts.src/components/inputs/upload-input-v3/index.js (1)
388-394:
⚠️ Potential issue | 🟠 Major | ⚡ Quick winAdd
rel="noopener noreferrer"to the preview anchor opened in a new tab.Line 388 opens a new tab via
target="_blank"but omitsrel, which allows reverse-tabnabbing on external URLs.Suggested patch
- <a href={src} target="_blank" title={T.translate("upload_input_v3.see_preview")}> + <a + href={src} + target="_blank" + rel="noopener noreferrer" + title={T.translate("upload_input_v3.see_preview")} + >📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.<a href={src} target="_blank" rel="noopener noreferrer" title={T.translate("upload_input_v3.see_preview")} > <ProgressiveImg alt={filename} src={previewSrc} placeholderSrc={file_icon} /> </a>🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/components/inputs/upload-input-v3/index.js` around lines 388 - 394, The anchor that opens the preview in a new tab (the <a> wrapping ProgressiveImg, using props src, previewSrc and title from T.translate("upload_input_v3.see_preview")) uses target="_blank" but lacks rel attributes; update that anchor to include rel="noopener noreferrer" to prevent reverse-tabnabbing when opening external URLs while keeping the existing target and children intact.
- @mui/material: ^6.4.3 → ^9.0.0 - @mui/icons-material: ^6.4.3 → ^9.0.0 - @mui/x-date-pickers: ^7.26.0 → ^9.0.0 (v9 targets MUI v9) - @emotion/react: ^11.11.4 → ^11.14.0 - @emotion/styled: ^11.11.5 → ^11.14.0 - react / react-dom: ^17.0.0 → ^18.0.0 (MUI v9 dropped React 17) - @testing-library/react: 12.1.5 → ^14.0.0 (RTL 12 supports React 17 only) peerDependencies updated to match: - react / react-dom: ^18.0.0 || ^19.0.0 - @emotion/*: ^11.0.0 (broader range for consumers) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Grid2 → Grid in item-price-tiers, additional-input, meta-field-values - InputProps → slotProps.input in meta-field-values (TextField endAdornment) - inputProps → slotProps.htmlInput in mui-formik-pricefield, mui-formik-quantity-field, item-price-tiers (Checkbox) - Autocomplete renderInput: params.InputProps → params.slotProps in company-input-mui, sponsorship-input-mui, mui-sponsor-input - MuiFormikTextField: deep-merge external slotProps.htmlInput with internal maxLength - MenuListProps → slotProps.list in menu-button - ErrorOutline → ErrorOutlined in upload-input-v3 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- MuiFormikSwitch: getByRole("checkbox") → getByRole("switch") (MUI v9 uses role=switch)
- MuiFormikDatepicker: getByLabelText → getByRole("group")/getByRole("spinbutton")
(x-date-pickers v9 renders spinbutton sections, not a plain input)
- FormItemTable: drop MUI MenuItem children from select mock (MenuItem now requires
MenuListContext; rendering it inside native <select> crashes in v9)
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Skips 5.x series to signal breaking peer-dep change (@mui/material ^9.0.0, react ^18||^19). Consumers must upgrade MUI and React before installing this version. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…emTable Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
santipalenque
force-pushed
the
feature/upgrade-mui-v9
branch
from
463db6b to
4e2078d
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/components/mui/GridFilter/components/Filter.jsx`:
- Line 16: The component imports MUI v1 Grid but uses the Grid2 API's size prop;
update the import to use Grid2 (the Grid2 component) from `@mui/material` (replace
the existing Grid import) so the existing usages of size on the Grid items (in
Filter.jsx) work correctly; ensure any references to Grid in this file (e.g.,
Grid used around the filter controls and IconButton areas) now refer to Grid2 so
layout (11/1 splits) renders as intended.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: a2e11671-9cd2-4b68-8c96-874e50333bfd
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (8)
.github/workflows/build_test.yml.github/workflows/jest.yml.nvmrcpackage.jsonsrc/components/mui/FormItemTable/index.jssrc/components/mui/GridFilter/components/Filter.jsxsrc/utils/__tests__/actions.test.jswebpack.common.js
💤 Files with no reviewable changes (1)
- src/utils/tests/actions.test.js
✅ Files skipped from review due to trivial changes (1)
- .github/workflows/jest.yml
🚧 Files skipped from review as they are similar to previous changes (1)
- package.json
| import React, { useEffect } from "react"; | ||
| import T from "i18n-react/dist/i18n-react"; | ||
| import { Box, Grid2, IconButton } from "@mui/material"; | ||
| import { Box, Grid, IconButton } from "@mui/material"; |
There was a problem hiding this comment.
Grid v1 component imported but Grid2 API (size prop) is used.
The code imports Grid (v1) from @mui/material at line 16, but uses the size prop at lines 84 and 114, which is the Grid2 API. Grid v1 does not recognize the size prop and uses xs, sm, md, lg, xl instead. This will cause the layout to break—the grid items will likely render at full width instead of 11/1 column splits.
In MUI v9, Grid2 is stable and should be used with the size prop.
🔧 Fix: Import and use Grid2
-import { Box, Grid, IconButton } from "`@mui/material`";
+import { Box, IconButton } from "`@mui/material`";
+import Grid from "`@mui/material/Grid2`";The rest of the code (using size prop) is already correct for Grid2.
Also applies to: 83-135
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/components/mui/GridFilter/components/Filter.jsx` at line 16, The
component imports MUI v1 Grid but uses the Grid2 API's size prop; update the
import to use Grid2 (the Grid2 component) from `@mui/material` (replace the
existing Grid import) so the existing usages of size on the Grid items (in
Filter.jsx) work correctly; ensure any references to Grid in this file (e.g.,
Grid used around the filter controls and IconButton areas) now refer to Grid2 so
layout (11/1 splits) renders as intended.
- Remove invalid offset={4} from Grid container in MetaFieldValues (offset is item-level only)
- Replace inputProps spread on Select with explicit error/helperText props wrapped in FormControl/FormHelperText so validation state actually renders
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/components/mui/__tests__/mui-formik-summit-addon-select.test.js (1)
58-75: ⚡ Quick winAlign the migrated test intent and assert
helperTextpropagation.The test name still references
inputProps, and it doesn’t assert the newhelperTextcontract.Proposed test update
- test("passes error to inputProps when touched and has error", () => { + test("passes error and helperText when touched and has error", () => { @@ expect(screen.getByTestId("summit-addon-select")).toHaveAttribute( "data-error", "true" ); + expect(screen.getByTestId("summit-addon-select")).toHaveAttribute( + "data-helper-text", + "Required" + ); });🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/components/mui/__tests__/mui-formik-summit-addon-select.test.js` around lines 58 - 75, The test "passes error to inputProps when touched and has error" still references the old inputProps contract after migration to helperText. Update the test name to reflect that it now tests helperText propagation, and add an assertion that verifies the helperText containing "Required" is actually rendered and displayed when the field is touched and has an error. The current assertion only checks the data-error attribute but does not validate that the error message itself is passed through as helperText to the user.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@src/components/mui/__tests__/mui-formik-summit-addon-select.test.js`:
- Around line 58-75: The test "passes error to inputProps when touched and has
error" still references the old inputProps contract after migration to
helperText. Update the test name to reflect that it now tests helperText
propagation, and add an assertion that verifies the helperText containing
"Required" is actually rendered and displayed when the field is touched and has
an error. The current assertion only checks the data-error attribute but does
not validate that the error message itself is passed through as helperText to
the user.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 405cb2f5-ad87-4a1f-a98f-8904586e77b7
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (36)
.github/workflows/build_test.yml.github/workflows/jest.yml.nvmrcpackage.jsonsrc/components/inputs/company-input-v2.jssrc/components/inputs/upload-input-v3/index.jssrc/components/mui/FormItemTable/__tests__/FormItemTable.test.jssrc/components/mui/FormItemTable/index.jssrc/components/mui/GridFilter/components/Filter.jsxsrc/components/mui/__tests__/additional-input-list.test.jssrc/components/mui/__tests__/additional-input.test.jssrc/components/mui/__tests__/meta-field-values.test.jssrc/components/mui/__tests__/mui-formik-datepicker.test.jssrc/components/mui/__tests__/mui-formik-summit-addon-select.test.jssrc/components/mui/__tests__/mui-formik-switch.test.jssrc/components/mui/cards/InlineCard/index.jssrc/components/mui/cards/TableCard/index.jssrc/components/mui/formik-inputs/additional-input/additional-input.jssrc/components/mui/formik-inputs/additional-input/meta-field-values.jssrc/components/mui/formik-inputs/company-input-mui.jssrc/components/mui/formik-inputs/item-price-tiers.jssrc/components/mui/formik-inputs/mui-formik-async-select.jssrc/components/mui/formik-inputs/mui-formik-pricefield.jssrc/components/mui/formik-inputs/mui-formik-summit-addon-select.jssrc/components/mui/formik-inputs/mui-formik-textfield.jssrc/components/mui/formik-inputs/mui-sponsor-input.jssrc/components/mui/formik-inputs/sponsorship-input-mui.jssrc/components/mui/menu-button.jssrc/components/mui/summit-addon-select.jssrc/components/mui/table/extra-rows/DiscountRow.jsxsrc/components/mui/table/extra-rows/FeeRow.jsxsrc/components/mui/table/extra-rows/PaymentRow.jsxsrc/components/mui/table/extra-rows/RefundRow.jsxsrc/utils/__tests__/actions.test.jssrc/utils/methods.jswebpack.common.js
💤 Files with no reviewable changes (1)
- src/utils/tests/actions.test.js
✅ Files skipped from review due to trivial changes (9)
- .github/workflows/build_test.yml
- src/components/mui/cards/InlineCard/index.js
- src/components/mui/table/extra-rows/PaymentRow.jsx
- .nvmrc
- src/components/mui/cards/TableCard/index.js
- src/components/mui/table/extra-rows/DiscountRow.jsx
- src/components/mui/table/extra-rows/RefundRow.jsx
- src/components/mui/tests/additional-input.test.js
- src/utils/methods.js
🚧 Files skipped from review as they are similar to previous changes (20)
- src/components/mui/tests/mui-formik-switch.test.js
- src/components/inputs/company-input-v2.js
- src/components/inputs/upload-input-v3/index.js
- src/components/mui/formik-inputs/item-price-tiers.js
- src/components/mui/tests/additional-input-list.test.js
- src/components/mui/formik-inputs/company-input-mui.js
- src/components/mui/formik-inputs/mui-sponsor-input.js
- src/components/mui/table/extra-rows/FeeRow.jsx
- .github/workflows/jest.yml
- src/components/mui/formik-inputs/sponsorship-input-mui.js
- src/components/mui/GridFilter/components/Filter.jsx
- src/components/mui/formik-inputs/mui-formik-pricefield.js
- src/components/mui/FormItemTable/index.js
- src/components/mui/formik-inputs/mui-formik-textfield.js
- src/components/mui/tests/mui-formik-datepicker.test.js
- src/components/mui/FormItemTable/tests/FormItemTable.test.js
- webpack.common.js
- src/components/mui/formik-inputs/mui-formik-async-select.js
- package.json
- src/components/mui/formik-inputs/additional-input/additional-input.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://app.clickup.com/t/86ba1zv3c
Summary by CodeRabbit
Release Notes
Chores
Refactor