Skip to content

Remove comment translation markers#1411

Merged
janrysavy merged 1 commit into
OpenSalamander:mainfrom
janrysavy:codex/remove-translation-markers
Jun 1, 2026
Merged

Remove comment translation markers#1411
janrysavy merged 1 commit into
OpenSalamander:mainfrom
janrysavy:codex/remove-translation-markers

Conversation

@janrysavy

@janrysavy janrysavy commented May 31, 2026

Copy link
Copy Markdown
Contributor

Summary

  • remove obsolete CommentsTranslationProject: TRANSLATED marker lines after the comment translation work was completed
  • cover all marker spellings used in source, help CSS, text, and batch files
  • preserve existing BOM/EOL/formatting; no unrelated normalization changes are included

Validation

  • ran normalize.ps1; then removed unrelated clang-format normalization from the PR scope
  • git diff --check upstream/main
  • verified rg "CommentsTranslationProject:\\s*TRANSLATED" . no longer finds marker lines
  • verified at Git blob/index level that every changed file equals the upstream blob with only the marker line removed, preserving BOM where present

@janrysavy janrysavy force-pushed the codex/remove-translation-markers branch 3 times, most recently from c6e8977 to c7a42e6 Compare May 31, 2026 17:21
@janrysavy janrysavy force-pushed the codex/remove-translation-markers branch from c7a42e6 to 29089c4 Compare May 31, 2026 17:26
@janrysavy janrysavy marked this pull request as ready for review May 31, 2026 17:33
@janrysavy janrysavy merged commit 73cd017 into OpenSalamander:main Jun 1, 2026
4 checks passed
0xeb added a commit to 0xeb/sally that referenced this pull request Jun 29, 2026
Record reviewed upstream ancestry with -s ours so GitHub reports 0 behind.

Merge-base: 825f8cb
Upstream head: 86a183f
Divergence before: fork-only 706, upstream-only 6
Substance hunt: files-touched 449; comment-only 406; CODE-CHANGED 11; ADDED 0; DELETED 0; RAW 32

Adopted: none.
Skipped:
- 406 source files identical after comment stripping/whitespace normalization.
- 11 CODE-CHANGED files only translate TRACE/message text or fix English wording; no behavior change.
- 32 RAW files are workflow/readme/help/CSS/text cleanup tied to upstream comment-translation maintenance and not applicable to Sally.

Upstream-only commits reviewed:
- fcd8322 Fix translated comment wording (OpenSalamander#1406)
- b95c9ce Translate Czech trace messages (OpenSalamander#1407)
- 91c9c7b Remove Cursor translation rules (OpenSalamander#1408)
- c1023fa Remove comment translation workflows (OpenSalamander#1409)
- 73cd017 Remove comment translation markers (OpenSalamander#1411)
- 86a183f Remove outdated Czech comment translation note from README (OpenSalamander#1413)
@janrysavy janrysavy deleted the codex/remove-translation-markers branch July 3, 2026 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant