Skip to content

docs(config_guide): add case management and GRM guides#133

Open
emjay0921 wants to merge 1 commit intov2-in-progress-3from
fix/config-guide-826-case-grm
Open

docs(config_guide): add case management and GRM guides#133
emjay0921 wants to merge 1 commit intov2-in-progress-3from
fix/config-guide-826-case-grm

Conversation

@emjay0921
Copy link
Copy Markdown
Contributor

Why is this change needed?

Adds configuration guides for case management and grievance redress mechanism (GRM).

How was the change implemented?

  • Added config_guide/case_management/ (index.md, overview.md, stages.md, teams.md) — domains, stages, teams, risk factors
  • Added config_guide/grievance_redress/ (index.md, overview.md, sla_rules.md, teams_tags.md) — categories, SLA, teams, tags
  • Added 10 screenshots
  • QA verified: case type domains (10 including "Other"), stage phases (7), GRM channels (4 defaults, configurable)

Related links

https://projects.acn.fr/projects/acn-eng/work_packages/826

@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces comprehensive documentation for Case Management and Grievance Redress Mechanism (GRM) configurations, covering mental models, key concepts, and setup guides for both modules. Feedback was provided regarding the SLA rules documentation, specifically pointing out an inconsistency where the described 'Escalation chain' pattern implies multiple escalation points and notification actions that are not supported by the single-field configuration schema defined earlier in the document.

Comment on lines +101 to +109
### Pattern 3: Escalation chain

Progressive escalation as deadlines approach:

| Escalation Point | After | Action |
|-----------------|-------|--------|
| First warning | 50% of response time | Notify assigned agent |
| Escalation | 100% of response time | Escalate to team supervisor |
| Critical escalation | 150% of response time | Escalate to program manager |
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The 'Escalation chain' pattern described here appears to be inconsistent with the configuration fields defined earlier in the document (lines 23-35). The configuration table only lists single fields for Escalate After, Escalate To User, and Escalate To Team, which suggests that only one escalation point can be configured per rule. Additionally, the 'Action' column mentions 'Notify assigned agent', but there is no notification action or email template field mentioned in the SLA rule configuration. Finally, '50% of response time' is not a valid input for the Escalate After field, which expects a numeric value in hours. Please clarify if this pattern requires multiple rules or if the system supports multiple escalation lines per rule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant