Fix default data pada IdentitasSeeder - #1271
Merged
Merged
Conversation
|
🔄 AI PR Review sedang antri di server...
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request: Fix default data pada IdentitasSeeder
Description
Perbaikan data default pada
database/seeders/IdentitasSeeder.phpyang sebelumnya menggunakan data milik Kota Bima (Simatik, kode 52.72). Data spesifik ini membuat bingung pengguna karena seolah-olah identitas aplikasi sudah lengkap padahal belum tentu sesuai dengan kabupaten yang menggunakannya.Changes made:
nama_aplikasidari'Simatik'menjadi'OpenKab'nama_kabupatendari'KOTA BIMA'menjadi'Belum Ditentukan'kode_kabupatendari'52.72'menjadi'00.00'nama_provinsidari'Nusa Tenggara Barat'menjadi'Belum Ditentukan'kode_provinsidari'52'menjadi'00'sebutan_kabdari'Kota'menjadi'Kabupaten'sebutan_desadari'Kelurahan'menjadi'Desa'returnstatement pada methodrun()(seharusnya void)Reason for change:
'Belum Ditentukan'dan'00.00'lebih jelas sebagai penanda bahwa data belum diisiImpact of change:
✅ Clarity: Pengguna baru langsung tahu bahwa data identitas belum diisi
✅ Consistency: Seeder tidak lagi memihak pada daerah tertentu
✅ Correctness: Mengembalikan return type ke
voidsesuai konvensi Laravel seederRelated Issue
#1270
Steps to Reproduce
Before fix (problem):
php artisan db:seedidentitasAfter fix (solution):
php artisan db:seedidentitasBelum Ditentukan,00.00)Checklist
Technical Details
Technical Explanation
Perubahan dilakukan pada file
database/seeders/IdentitasSeeder.php. Data array$defaultDatadiubah dari data hardcoded Kota Bima menjadi data placeholder generik. Selain itu,returnstatement dihapus karena methodrun()pada Seeder seharusnya returnvoid.Dependencies added
Testing
Manual Testing
php artisan db:seedidentitasadalah data generikVideo
simplescreenrecorder-2026-08-27_05.49.14.mp4
simplescreenrecorder-2026-08-27_05.53.48.mp4
None
Migration Guide
Not required
References
Additional notes: Perubahan ini bersifat backward-compatible. Pengguna yang sudah memiliki data identitas tidak akan terpengaruh karena seeder hanya berjalan pada fresh install.