Skip to content

Fun new command called bleach - #34

Open
JustBleachGuy wants to merge 1 commit into
OpenRedstoneEngineers:masterfrom
JustBleachGuy:patch-1
Open

Fun new command called bleach#34
JustBleachGuy wants to merge 1 commit into
OpenRedstoneEngineers:masterfrom
JustBleachGuy:patch-1

Conversation

@JustBleachGuy

Copy link
Copy Markdown

Cool new command /bleach

Cool new command /bleach
"localChat": "Follow this link to find information about the current owner: <aqua><click:open_url:'https://openredstone.org/owner'><hover:show_text:'Go to URL'>https://openredstone.org/owner</hover></click></aqua>"
},
{
"command": "bleach",

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the command

@JoBeGaming

Copy link
Copy Markdown

Uhh not to be mean or anything, but have there been requests for the addition of this command?

@JustBleachGuy

Copy link
Copy Markdown
Author

Uhh not to be mean or anything, but have there been requests for the addition of this command?

What do you mean?

@JoBeGaming

Copy link
Copy Markdown

Uhh not to be mean or anything, but have there been requests for the addition of this command?

What do you mean?

Just asking why you are wanting to add this? Usually commands are requested by the community as a whole.

@JustBleachGuy

Copy link
Copy Markdown
Author

Uhh not to be mean or anything, but have there been requests for the addition of this command?

What do you mean?

Just asking why you are wanting to add this? Usually commands are requested by the community as a whole.

Ahhh ok so where can i make a suggestion for it in the discord?

@JoBeGaming

Copy link
Copy Markdown

Uhh not to be mean or anything, but have there been requests for the addition of this command?

What do you mean?

Just asking why you are wanting to add this? Usually commands are requested by the community as a whole.

Ahhh ok so where can i make a suggestion for it in the discord?

It's not really about the suggestion itself, it was rather about me being surprised this is proposed at all, because usually the request to add it comes from multiple members first, then later you ask Staff. Also I feel like some <name> pours bleach in eyes is a bit uhh bad I guess. I mean we have bad stuff, but I'd hate for ORE to be the reason that some random kid tries that lol. Although then again im neither Admin nor Mod, so I'm not the one deciding this. Perhaps Nick could take a look at this later (not a lot to review itself, as the commit is quite simple).

@JustBleachGuy

Copy link
Copy Markdown
Author

Uhh not to be mean or anything, but have there been requests for the addition of this command?

What do you mean?

Just asking why you are wanting to add this? Usually commands are requested by the community as a whole.

Ahhh ok so where can i make a suggestion for it in the discord?

It's not really about the suggestion itself, it was rather about me being surprised this is proposed at all, because usually the request to add it comes from multiple members first, then later you ask Staff. Also I feel like some <name> pours bleach in eyes is a bit uhh bad I guess. I mean we have bad stuff, but I'd hate for ORE to be the reason that some random kid tries that lol. Although then again im neither Admin nor Mod, so I'm not the one deciding this. Perhaps Nick could take a look at this later (not a lot to review itself, as the commit is quite simple).

Yes i understand, other members have commands like /ribbit. I asked how to get one/recommend one and they told me to do this. Though thank you for telling me this because next time ill improve the command :D

@JoBeGaming

Copy link
Copy Markdown

Uhh not to be mean or anything, but have there been requests for the addition of this command?

What do you mean?

Just asking why you are wanting to add this? Usually commands are requested by the community as a whole.

Ahhh ok so where can i make a suggestion for it in the discord?

It's not really about the suggestion itself, it was rather about me being surprised this is proposed at all, because usually the request to add it comes from multiple members first, then later you ask Staff. Also I feel like some <name> pours bleach in eyes is a bit uhh bad I guess. I mean we have bad stuff, but I'd hate for ORE to be the reason that some random kid tries that lol. Although then again im neither Admin nor Mod, so I'm not the one deciding this. Perhaps Nick could take a look at this later (not a lot to review itself, as the commit is quite simple).

Yes i understand, other members have commands like /ribbit. I asked how to get one/recommend one and they told me to do this. Though thank you for telling me this because next time ill improve the command :D

Oh, to be honest I've never heard of /ribbit, nor have I seen anyone use it before. Perhaps that kinda shows that fun-commands oriented at players often don't get used a lot. Still go ahead with the PR if you want to, I know it might have sounded like I was discouraging this or something, when I actually was just somewhat wondering why the PR got created in the first place. I think asking for a personal command for Patrick (just ask some mod to add ,bleach or so) would be better, as that would likely be used more often. Also sometimes I guess command additions to ChattORE (which IIRC originally wasn't meant to go with funcommands, with that being a seperate plugin (which I think could be better but thats just my opinon)) don't get merged at all, even if its just some simple change. Look e.g. at #16 and #20. Then again though, PRs like #14 and #28 (which you mentioned) got merged. I'm not too sure how mods plan to do this in the future, and it's not a lot of requests like this anyways, but the rate at which such person-specific command requests are being made (/fan in #14, /ribbit in #28) is increasing. Perhaps a way to ,add <cmd> <formatted-response> would be good for Patrick, basically what you are doing here, so you could do ,add bleach <username> thinks bleach is good for your eyes.. That's all just my opinion though, feel free to do whatever you think is best.

(Also I actually like the <formatted-response> idea I got, might make a PR for that in Patrick soon.)

Oh and Nick if you are reading this, sorry for flooding #chattore channel xd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants