Skip to content

Some formatting changes, but more importantly ingame replies and discord replies show up ingame - #33

Open
Wueffi wants to merge 8 commits into
OpenRedstoneEngineers:masterfrom
Wueffi:master
Open

Some formatting changes, but more importantly ingame replies and discord replies show up ingame #33
Wueffi wants to merge 8 commits into
OpenRedstoneEngineers:masterfrom
Wueffi:master

Conversation

@Wueffi

@Wueffi Wueffi commented Aug 21, 2026

Copy link
Copy Markdown
Member

This PR adds what the name says, you can hover the reply part to show the reference message.
image

@Nickster258 Nickster258 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick, admittedly petty, note on messageID.

Comment thread chattore/src/main/kotlin/feature/Discord.kt Outdated

@paulikauro paulikauro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick review, will have to think more later! For Kotlin files, check formatting (mostly trailing commas) and redundant imports

Comment thread chattore/src/main/kotlin/feature/ChatReply.kt Outdated
Comment thread chattore/src/main/kotlin/feature/ChatReply.kt Outdated
Comment thread chattore/src/main/kotlin/feature/ChatReply.kt Outdated
Comment thread chattore/src/main/kotlin/feature/ChatReply.kt Outdated
Comment thread chattore/src/main/kotlin/feature/ChatReply.kt Outdated
Comment thread chattore/src/main/kotlin/feature/Discord.kt Outdated
Comment thread chattore/src/main/kotlin/feature/Discord.kt Outdated
Comment thread chattore/src/main/kotlin/feature/Discord.kt Outdated
Comment thread chattore/src/main/kotlin/Messenger.kt Outdated
Comment thread chattore/src/main/kotlin/feature/ChatReply.kt Outdated
@Wueffi

Wueffi commented Aug 22, 2026

Copy link
Copy Markdown
Member Author

Done the changes

Comment thread chattore/src/main/kotlin/feature/ChatReply.kt Outdated
Comment thread chattore/src/main/kotlin/feature/ChatReply.kt Outdated
Comment thread chattore/src/main/kotlin/feature/ChatReply.kt Outdated
Comment thread chattore/src/main/kotlin/feature/Discord.kt Outdated
Comment thread chattore/src/main/kotlin/feature/ChatReply.kt Outdated
@Wueffi
Wueffi requested a review from paulikauro August 22, 2026 11:40
@Wueffi

Wueffi commented Aug 22, 2026

Copy link
Copy Markdown
Member Author

Refactor #2 done

Comment thread chattore/src/main/kotlin/feature/Bubble.kt
val content: String,
)

class ChatReply() {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, but redundant parens (IDEA should tell you this with a gray color)

Comment thread chattore/src/main/kotlin/feature/ChatReply.kt Outdated
Comment thread chattore/src/main/kotlin/feature/ChatReply.kt Outdated
Comment thread chattore/src/main/kotlin/Messenger.kt
Comment thread chattore/src/main/kotlin/Messenger.kt Outdated
Comment thread chattore/src/main/kotlin/Messenger.kt Outdated
Comment thread chattore/src/main/kotlin/Messenger.kt
@Wueffi
Wueffi requested a review from paulikauro August 23, 2026 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants