fix: resolve SonarCloud quality gate findings - #999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolve the SonarCloud quality-gate failures reported by PR #998.
Root cause
The
devPR introduced nine maintainability violations: composite assertions in tests, a one-line source-file length threshold breach, and a long generated-schema assembly function.Changes
Validation
uv run --directory implementations/python --extra dev pytest tests/test_issue_811_participant_bisimulation_design.py tests/test_asr_535_participant_flow_assurance.py tests/test_sem_218_realization_designation.py(48 passed)uv tool run ruff checkon changed filestools/check_repo_policy.pytools/check_requirement_governance.py(Ground Control service unavailable; checker skipped its remote lookup)Targets
devso the original PR can be rerun.