Skip to content

fix: reduce claim binding validation complexity - #979

Merged
Brad-Edwards merged 1 commit into
devfrom
977-sonar-function-complexity
Jul 29, 2026
Merged

fix: reduce claim binding validation complexity#979
Brad-Edwards merged 1 commit into
devfrom
977-sonar-function-complexity

Conversation

@Brad-Edwards

Copy link
Copy Markdown
Collaborator

Summary

Reduces the SonarCloud-reported complexity in validate_behavioral_claim_binding, the function actually associated with the open issue on #977.

Related issues

  • Addresses the remaining SonarCloud quality-gate finding on Dev #977.

Changes

  • Extract taxonomy and relation resolution into a focused helper.
  • Validate required relation bindings through a compact requirement table.
  • Preserve all existing validation errors and return behavior.

Test plan

  • 103 behavioral-relation, opacity, and repeatability tests pass
  • Repository lint passes
  • Repository policy check passes
  • Module complexity audit reports a maximum of 9 and the flagged function at 2

Checklist

  • Code follows project coding standards
  • No semantic behavior change
  • No published contract schema changes
  • PR title is a Conventional Commit
  • No architectural documentation update needed

Notes for review

The prior fix refactored a different function because the Sonar line number was interpreted against the wrong source revision. This change follows the stable Sonar issue key to the actual function and audits the complete module against the same complexity threshold.

@Brad-Edwards
Brad-Edwards merged commit 6c582f2 into dev Jul 29, 2026
12 checks passed
@Brad-Edwards
Brad-Edwards deleted the 977-sonar-function-complexity branch July 29, 2026 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant