ci: let the docker integration lane fail the build - #1161
Open
doublewhy wants to merge 1 commit into
Open
Conversation
The integration-docker job carried continue-on-error: true, so a real failure in the container integration session never failed CI even though every GitHub-hosted runner has a docker runtime -- the reference OCI driver's real container IO was exercised by a lane that could not gate. Remove the blanket pass; the existing runtime probe still skips the session cleanly on runners without a container runtime. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plain-language summary
integration-dockerran withcontinue-on-error: true, so a genuine failure in the container integration session never failed the build — even though GitHub-hosted runners always have docker. The reference OCI driver's real container IO (_default_runner, deliberately excluded from hermetic coverage) was exercised only by a lane that could not gate: a closed blind spot around the only code that touches a real runtime.Verification
integration-dockercheck demonstrates the gating path live.🤖 Generated with Claude Code