fix(conformance): keep the default adapter probe envelope-neutral - #1159
Open
doublewhy wants to merge 1 commit into
Open
fix(conformance): keep the default adapter probe envelope-neutral#1159doublewhy wants to merge 1 commit into
doublewhy wants to merge 1 commit into
Conversation
Carrying authored OS identity through realization (#1141) turned the default target-conformance probe scenario's 'os: linux' into an exact SEM-218 os-family requirement demanding presence corroboration that no hermetic in-process backend declares. Since then target-provisioning and target-snapshot silently failed for every honest backend (reference and stub alike), with no test pinning them. Drop the authored OS from the default probe scenario — mirroring the canonical cross-backend-minimal decision that leaving it unset is what keeps a scenario admissible on more than one envelope — and pin both adapter probes passing for every hermetic backend so this cannot drift silently again. The issue #663 runner parameter remains the escape hatch for bounded backends, and the pinned fail-closed posture of the opacity and constructive-envelope probes (report.passed is False) is unchanged. Advances RUN-314's acceptance criterion that the released conformance harness be invocable by a downstream backend with default arguments. Verification: reference and stub targets both pass target-provisioning and target-snapshot; nox -s tests green (7,012 tests); ruff clean; check_repo_policy pass. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plain-language summary
run_target_conformancewith default arguments fails even the honest reference backend.os: linuxdemands exact SEM-218 os-family corroboration that no hermetic in-process backend declares — sotarget-provisioningandtarget-snapshotsilently fail for every honest backend (reference and stub alike), and nothing pinned them.cross-backend-minimaldecision that leavingosunset keeps a scenario admissible on more than one envelope) and pin both adapter probes passing for every hermetic backend.Issue mapping
reference_scenario=runner parameter remains the escape hatch for bounded/fixed-topology backends.Summary
raes_conformance/conformance/target_probes.py: the default conformance scenario no longer authorsos: linux; the comment records why (an authored OS is an exact realization requirement, not adapter mechanics — the SEM-218 probes own that concern).tests/test_reference_backend_conformance.py: newtest_adapter_probes_pass_for_every_hermetic_backendpinstarget-provisioningandtarget-snapshotpassing for the reference and stub targets, so the probe cannot silently regress again.report.passedstaysFalsefor the reference target (opacity and constructive-envelope probes still reportunsupported), exactly astest_reference_target_requires_opacity_probe_for_positive_declarationrequires.Compatibility
reference_scenarioare unaffected.Verification
target-provisioningandtarget-snapshot; full report posture unchanged.nox -s tests: 7,012 passed; coverage gate green.tools/check_repo_policy.pypass.🤖 Generated with Claude Code