Skip to content

refactor(tools): decompose oversized governance checkers into support packages #1157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
doublewhy merged 1 commit into from
Aug 14, 2026
Merged

refactor(tools): decompose oversized governance checkers into support packages #1157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions implementations/python/tests/test_formal_semantic_validation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,10 @@ def test_historical_release_validation_does_not_replay_current_code(
def fail_if_replayed(*_args: object, **_kwargs: object) -> dict[str, object]:
raise AssertionError("historical evidence must not replay current code")

monkeypatch.setattr(formal_validation, "replay_case", fail_if_replayed)
from tools.formal_semantic_validation import _retest, _snapshot

monkeypatch.setattr(_snapshot, "replay_case", fail_if_replayed)
monkeypatch.setattr(_retest, "replay_case", fail_if_replayed)

assert validate_release_bundle(REPO_ROOT, release) == []

Expand Down Expand Up @@ -201,7 +204,9 @@ def replace_stored_evidence(repo_root: Path, relative_path: str, *, max_bytes: i
return replacement
return original_loader(repo_root, relative_path, max_bytes=max_bytes)

monkeypatch.setattr(formal_validation, "load_bounded_json_object", replace_stored_evidence)
from tools.formal_semantic_validation import _production

monkeypatch.setattr(_production, "load_bounded_json_object", replace_stored_evidence)

failures = validate_retest_bundle(REPO_ROOT, release, protocol, corpus, snapshot, analysis)

Expand Down Expand Up @@ -364,7 +369,7 @@ def test_participant_test_replay_maps_pytest_status(
expected: tuple[bool, str],
) -> None:
monkeypatch.setattr(
"tools.check_formal_semantic_validation.subprocess.run",
"tools.formal_semantic_validation._replay.subprocess.run",
lambda *_args, **_kwargs: SimpleNamespace(returncode=returncode),
)

Expand All @@ -375,7 +380,7 @@ def test_participant_test_replay_fails_closed_on_timeout(monkeypatch: pytest.Mon
def timed_out(*_args: object, **_kwargs: object) -> None:
raise subprocess.TimeoutExpired(cmd="pytest", timeout=600)

monkeypatch.setattr("tools.check_formal_semantic_validation.subprocess.run", timed_out)
monkeypatch.setattr("tools.formal_semantic_validation._replay.subprocess.run", timed_out)

ok, message = _replay_participant_tests(REPO_ROOT, ["tests/test_example.py::test_case"])

Expand Down
Loading