Skip to content

Avoid Unsloth import in Megatron service #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Kovbo wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −1
Draft

Avoid Unsloth import in Megatron service #686

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/art/megatron/service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import asyncio
from dataclasses import dataclass, field
import gc
import importlib
import os
from pathlib import Path
Expand All @@ -18,7 +19,6 @@
from ..local.checkpoints import get_last_checkpoint_dir
from ..preprocessing.pack import DiskPackedTensors
from ..preprocessing.tokenize import SFTBatch
from ..unsloth.train import gc_and_empty_cuda_cache
from ..utils.convert_moe_lora import convert_checkpoint_if_needed
from ..utils.get_model_step import get_step_from_dir
from ..utils.lifecycle import (
Expand Down Expand Up @@ -57,6 +57,13 @@
safe_open = safetensors.safe_open


def gc_and_empty_cuda_cache(n: int = 3) -> None:
for _ in range(n):
gc.collect()
if torch.cuda.is_available():
torch.cuda.empty_cache()


class _RuntimeRequestKwargs(TypedDict, total=False):
headers: dict[str, str]

Expand Down
Loading