fix: add missing runtime dependencies for torch-runtime install#115
Open
micheljung wants to merge 1 commit into
Open
fix: add missing runtime dependencies for torch-runtime install#115micheljung wants to merge 1 commit into
micheljung wants to merge 1 commit into
Conversation
Add accelerate to torch-runtime extras (required for device_map="auto" inference, not just finetuning) and document the FFmpeg system dependency in the README (required by torchcodec for audio I/O). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Collaborator
|
Looks good overall, and I think this is mergeable. One small documentation follow-up before merging would be ideal: the FFmpeg note is currently under the “Using Conda” section, but it also applies to the It would also be nice to mirror the same note in The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add accelerate to torch-runtime extras (required for device_map="auto" inference, not just finetuning) and document the FFmpeg system dependency in the README (required by torchcodec for audio I/O).