Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the npm publishing failure from Release run 26762519392.
Root cause
The Stage binaries step failed before npm publish. npm/stage-binaries.sh used a tar listing pipeline where awk exited immediately after finding the ok binary. Under set -o pipefail, tar can receive SIGPIPE while still listing later archive entries and fail with tar: stdout: write error.
Fix
The awk command now records the first ok path but consumes the full tar listing before exiting.
Verification
The new shell regression test is wired into CI so develop-to-master PRs catch this before release tags.