Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the Release workflow failure for the x86_64 macOS build by making the macOS crash-handler dependency available on all macOS targets, not only Apple Silicon.
Root cause
The failed Release run compiled src/security/mach_exception.rs for x86_64-apple-darwin, but mach2 was declared only for aarch64-apple-darwin. The module is gated by target_os macos, so the dependency needs the same target scope.
Verification
Release follow-up
After this merges to master, rerun the failed preview release by moving or recreating v0.8.0-preview.1 on the fixed master commit, or choose a new preview tag/version if you prefer not to move the failed tag.