Adds kh1ardresource method - #1277
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
shananas
reviewed
Aug 16, 2026
Matches every other patch method: mod.yml lists the asset and points at a file holding the edits, so the manifest only changes when an edit is added or removed. Replaces the inline 'replacements' map, which was the only inline-data property on AssetFile.
shananas
approved these changes
Aug 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small one. This adds the kh1ardresouce method.
KH1
*.ardfiles include a list of model/animation resource filenames that each room loads/uses.These references are in plain ASCII and are pointed to via offset at the beginning of the binary.
We can patch these by reading that offset and replacing the plaintext references by index since they all have the same size capacity.
I want to use this for KH1 enemy randomizer without replacing the entire
*.ardbinaries, not sure what else this would be used for.