Refactor curves.cpp - #483
Open
BryanSouza91 wants to merge 4 commits into
Open
Conversation
BryanSouza91
commented
Aug 3, 2025
BryanSouza91
left a comment
BryanSouza91
left a comment
Author
There was a problem hiding this comment.
Line 241 can be removed. I thought I had removed it in this commit.
Member
|
I tested it and it adds about 52 bytes of code therefore I'm not sure if it is worth merging if it's not solving any bug or other existing issue. |
…t is negligible; Keeping early exits for runtime performance;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were some calculations that were repeated multiple times in a single scope those were calculated once, stored and used as needed.
Split from #480