feat(rog-slash): add slash support for GU405 models by mig · Pull Request #292 · OpenGamingCollective/asusctl

mig · 2026-08-13T18:54:17Z

Description

Slash support for the ROG Zephyrus G14 GU405AR. Board name GU405AR, device 0b05:19b6.

[INFO  asusd::aura_types]   Unknown or invalid slash: "19b6", skipping
[INFO  asusd::aura_manager] Tested device was not Slash

This adds a GU405_2026 variant mapped to PROD_ID2 / REPORT_ID_19B6 plus a GU405 board-name match (I followed #281 for the GU606AX as an example).

Like the GU606AX, this laptop exposes a single HID interface, the slash shares it with the keyboard.

After the patch:

[INFO  asusd::aura_types] Found slash type GU405_2026: 19b6

$ busctl --system introspect xyz.ljones.Asusd /xyz/ljones/aura/19b6_2_5 xyz.ljones.Slash
NAME                TYPE     SIGNATURE RESULT/VALUE FLAGS
.DeviceState        method   -         (byyu)       -
.Brightness         property y         255          emits-change writable
.Enabled            property b         true         emits-change writable
.Interval           property y         0            emits-change writable
.Mode               property y         0            emits-change writable
.ShowOnBoot         property b         true         emits-change writable
...

Enable, brightness, and mode changes all working.

Tested Hardware & Environment

ASUS Laptop Model: ROG Zephyrus G14 GU405AR
Linux Distribution: Arch
Kernel Version: 7.1.8-arch1-3

Verification and testing:

I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My code follows the style guidelines of this project (cargo fmt --all -- --check)
My changes generate no new warnings (cargo clippy --all -- -D warnings)
New and existing unit tests pass locally with my changes (cargo test --all)
Cranky with 0 warning (cargo cranky)

The 2026 G14 (GU405AR) exposes the slash device as 0b05:19b6, the same controller generation as GU605_2025, but fell through to Unsupported as there was no matching board name. Add a GU405_2026 variant mapped to PROD_ID2 / REPORT_ID_19B6 and match on a GU405 board name in both from_dmi() and get_slash_type().

coderabbitai · 2026-08-13T18:54:51Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: b280cce9-aca5-4b28-a997-92d25cb14550

📥 Commits

Reviewing files that changed from the base of the PR and between c8d389d and a779e0d.

📒 Files selected for processing (2)

rog-slash/src/data.rs
rog-slash/src/usb.rs

📜 Recent review details

🧰 Additional context used

🧠 Learnings (1)

📓 Common learnings

Learnt from: NB-Group
Repo: OpenGamingCollective/asusctl PR: 230
File: rog-control-center/ui/pages/slash.slint:0-0
Timestamp: 2026-07-29T04:11:38.960Z
Learning: In `rog-control-center/ui/pages/slash.slint`, asusd's Slash interface has no theme concept. Do not add theme-selection controls to the Slash UI unless corresponding backend support is introduced.

Learnt from: NB-Group
Repo: OpenGamingCollective/asusctl PR: 230
File: rog-control-center/ui/pages/slash.slint:174-185
Timestamp: 2026-07-29T15:23:06.899Z
Learning: For OpenGamingCollective/asusctl’s rog-control-center Slint UI, keyboard navigation, focus indicators, and accessible slider behavior should be addressed together in a follow-up PR by improving shared widgets, rather than through piecemeal per-page fixes or separate issues.

Learnt from: NB-Group
Repo: OpenGamingCollective/asusctl PR: 230
File: rog-control-center/ui/pages/slash.slint:497-527
Timestamp: 2026-07-29T15:16:53.348Z
Learning: In `rog-control-center/ui/pages/slash.slint`, Slash effect controls (mode, interval, and brightness) are intentionally disabled when `SlashPageData.enabled` is false to prevent backend changes while the physical Slash light bar is off. `SlashDevicePreview` remains animated independently so users can preview effects before enabling the bar.

🔇 Additional comments (2)

rog-slash/src/data.rs (1)

19-19: LGTM!

Also applies to: 35-35, 50-50, 76-77, 99-99

rog-slash/src/usb.rs (1)

32-32: LGTM!

📝 Walkthrough

Summary by CodeRabbit

New Features
- Added support for GU405 2026 devices.
- GU405 boards are now detected automatically.
- Added support for the GU405_2026 device identifier and USB communication mapping.

Walkthrough

Adds public SlashType::GU405_2026 support. DMI detection, string parsing, product mappings, and USB report ID handling now recognize GU405 boards.

Changes

GU405_2026 support

Layer / File(s)	Summary
SlashType detection and USB mapping `rog-slash/src/data.rs`, `rog-slash/src/usb.rs`	Adds the `GU405_2026` variant. Maps its product identifiers, recognizes `GU405` through DMI detection, accepts `"GU405_2026"` during parsing, and uses `REPORT_ID_19B6`.

Estimated code review effort: 2 (Simple) | ~10 minutes

Mergeability Score: ⚪ Minimal · up to a779e

This localized change adds GU405 slash-device support without any identified merge-blocking correctness, security, availability, or deployment risk; it is merge-ready after normal checks and review.

Possibly related issues

[Support] ASUS TUF Gaming A16 (FA608WV) keyboard backlight via HID LampArray (fix in PR #147) #148: Adds support for an ASUS device that uses product ID 0B05:19B6.

Possibly related PRs

OpenGamingCollective/asusctl#271: Adds support for an ASUS device using 19b6 and REPORT_ID_19B6.
OpenGamingCollective/asusctl#281: Adds another SlashType variant with matching detection, parsing, and REPORT_ID_19B6 mapping.
OpenGamingCollective/asusctl#285: Adds USB ID 19b6 handling in related Slash device code.

Suggested labels: enhancement, rog-slash

Suggested reviewers: boogie61

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main change: adding slash support for GU405 models.
Description check	✅ Passed	The description explains the change, tested hardware, environment, observed behavior, and verification results; non-critical unchecked items remain.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

scardracs · 2026-08-13T18:55:38Z

    GU605_2024,
    GU605_2025,
    GU606_2026,
+    GU405_2026,


Alphabetical order

scardracs · 2026-08-13T18:55:43Z

            SlashType::GU605_2025 => PROD_ID2,
            SlashType::GU605_2024 => PROD_ID1,
            SlashType::GU606_2026 => PROD_ID2,
+            SlashType::GU405_2026 => PROD_ID2,


Alphabetical order

scardracs · 2026-08-13T18:55:48Z

            SlashType::GU605_2025 => PROD_ID2_STR,
            SlashType::GU605_2024 => PROD_ID1_STR,
            SlashType::GU606_2026 => PROD_ID2_STR,
+            SlashType::GU405_2026 => PROD_ID2_STR,


Alphabetical order

scardracs · 2026-08-13T18:56:01Z

+        } else if board_name.contains("GU405") {
+            SlashType::GU405_2026


Alphabetical order

scardracs · 2026-08-13T18:56:07Z

            "GU605_2025" => Self::GU605_2025,
            "GU605_2024" => Self::GU605_2024,
            "GU606_2026" => Self::GU606_2026,
+            "GU405_2026" => Self::GU405_2026,


Alphabetical order

scardracs · 2026-08-13T18:56:12Z

        SlashType::GU605_2025 => REPORT_ID_19B6,
        SlashType::GU605_2024 => REPORT_ID_193B,
        SlashType::GU606_2026 => REPORT_ID_19B6,
+        SlashType::GU405_2026 => REPORT_ID_19B6,


Alphabetical order

Address review feedback

Ghoul4500

Thank you for your contribution

coderabbitai Bot added enhancement New feature or request rog-slash Slash LED Bar labels Aug 13, 2026

scardracs reviewed Aug 13, 2026

View reviewed changes

refactor(rog-slash): sort GU405_2026 variant alphabetically

a779e0d

Address review feedback

Ghoul4500 approved these changes Aug 13, 2026

View reviewed changes

Ghoul4500 merged commit b9be65d into OpenGamingCollective:main Aug 13, 2026
1 check passed

Navigation Menu

Uh oh!

feat(rog-slash): add slash support for GU405 models - #292

feat(rog-slash): add slash support for GU405 models#292
Ghoul4500 merged 2 commits into
OpenGamingCollective:mainfrom
mig:feat/slash-support-gu405

mig commented Aug 13, 2026

Uh oh!

coderabbitai Bot commented Aug 13, 2026 •

edited

Loading

Summary by CodeRabbit

Walkthrough

Changes

Uh oh!

scardracs Aug 13, 2026

Uh oh!

scardracs Aug 13, 2026

Uh oh!

scardracs Aug 13, 2026

Uh oh!

scardracs Aug 13, 2026

Uh oh!

scardracs Aug 13, 2026

Uh oh!

scardracs Aug 13, 2026

Uh oh!

Ghoul4500 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		} else if board_name.contains("GU405") {
		SlashType::GU405_2026

Uh oh!

Conversation

mig commented Aug 13, 2026

Description

Tested Hardware & Environment

Verification and testing:

Uh oh!

coderabbitai Bot commented Aug 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Walkthrough

Changes

Uh oh!

scardracs Aug 13, 2026

Choose a reason for hiding this comment

Uh oh!

scardracs Aug 13, 2026

Choose a reason for hiding this comment

Uh oh!

scardracs Aug 13, 2026

Choose a reason for hiding this comment

Uh oh!

scardracs Aug 13, 2026

Choose a reason for hiding this comment

Uh oh!

scardracs Aug 13, 2026

Choose a reason for hiding this comment

Uh oh!

scardracs Aug 13, 2026

Choose a reason for hiding this comment

Uh oh!

Ghoul4500 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

coderabbitai Bot commented Aug 13, 2026 •

edited

Loading