New badge QR page for user with summit hall checked in#105
Open
tomrndom wants to merge 6 commits into
Open
Conversation
✅ Deploy Preview for qa-fnvirtual ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
smarcet
reviewed
Aug 14, 2024
| import QRCode from "react-qr-code"; | ||
|
|
||
| import Layout from '../components/Layout' | ||
| import withOrchestra from "../utils/widgetOrchestra"; |
Contributor
There was a problem hiding this comment.
why do u need this one ?
i do think this is deprecated
smarcet
reviewed
Aug 14, 2024
| ) | ||
| }; | ||
|
|
||
| const OrchestedTemplate = withOrchestra(BadgePageTemplate); |
Contributor
There was a problem hiding this comment.
smarcet
reviewed
Aug 14, 2024
| ) => { | ||
| return ( | ||
| <Layout location={location}> | ||
| <OrchestedTemplate |
Contributor
There was a problem hiding this comment.
smarcet
reviewed
Aug 14, 2024
|
|
||
| return ( | ||
| <div className="px-6 py-6 mb-6"> | ||
| {hasBadgeChecked && |
Contributor
There was a problem hiding this comment.
this is redundant, arent u check in this on the custom route ?
smarcet
reviewed
Aug 14, 2024
|
|
||
| const handleBadgeChange = (ev) => { | ||
| const { target: { value } } = ev; | ||
| const newBadge = user.summit_tickets.find(e => e.id === value); |
Contributor
There was a problem hiding this comment.
this is a ticket not a badge
smarcet
reviewed
Aug 14, 2024
| </div> | ||
| <div className="columns mt-3"> | ||
| <div className={"column is-half-desktop is-full-mobile"}> | ||
| {currentBadge && |
Contributor
There was a problem hiding this comment.
current badge is a ticket u need to be consistent
ticket.badge.qr_code
smarcet
force-pushed
the
feature/badge-qr-page
branch
from
1c54656 to
aac4f40
Compare
smarcet
requested changes
Sep 4, 2024
Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
tomrndom
force-pushed
the
feature/badge-qr-page
branch
from
042ff40 to
a85d3d5
Compare
Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
smarcet
force-pushed
the
main
branch
3 times, most recently
from
69cd3a0 to
b1da769
Compare
smarcet
force-pushed
the
main
branch
2 times, most recently
from
1e50316 to
25e7aad
Compare
smarcet
force-pushed
the
main
branch
2 times, most recently
from
8be99ee to
0f07cd6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
No
What needs to be documented once your changes are merged?
Nothing
ref: https://tipit.avaza.com/project/view#!tab=task-pane&task=3615258
Signed-off-by: Tomás Castillo tcastilloboireau@gmail.com