chore(deps): bump @mikro-orm/sqlite from 6.6.14 to 6.6.15 - #148
chore(deps): bump @mikro-orm/sqlite from 6.6.14 to 6.6.15#148dependabot[bot] wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2c233a2398
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "@google/genai": "^1.52.0", | ||
| "@mikro-orm/core": "^6.6.14", | ||
| "@mikro-orm/sqlite": "^6.6.14", | ||
| "@mikro-orm/sqlite": "^6.6.15", |
There was a problem hiding this comment.
Keep MikroORM packages on the same version
When the ADK DatabaseSessionService initializes in server/agent/http.ts:createDefaultAgentHandler, it calls MikroORM.init(), whose package-version guard rejects official @mikro-orm/* packages that do not exactly match @mikro-orm/core. This line installs @mikro-orm/sqlite 6.6.15 while the previous line leaves @mikro-orm/core at 6.6.14, so the agent sidecar/session tests fail as soon as the SQLite session store initializes; bump core/reflection with the driver or keep sqlite at 6.6.14.
Useful? React with 👍 / 👎.
Automated Dependabot review — ⛔ stopped (fail-fast)Step 1 — Code review
Step 2/3 — Regression + CI: ❌ FAILED
Step 4 — Decision: Not merged. Per fail-fast, stopping here. To unblock: bump Generated by Claude Code |
Automated Dependabot review — ❌ blocked, not mergedStep 1 — Code review Step 2/3 — Regression / CI: FAILED Root cause: MikroORM enforces that every Step 4 — Decision: not merging (fail-fast). Generated by Claude Code |
2c233a2 to
e25faa1
Compare
Automated Dependabot review — ⛔ Blocked, not mergedStep 1 — Code review Scope is clean (only Step 2/3 — Regression & CI The required MikroORM enforces strict version lockstep: every official 13 sidecar tests fail as a result ( Recommended remediation — bump the two MikroORM packages together so
Leaving open for a maintainer decision. Generated by Claude Code |
Automated Dependabot review — ❌ blocked, not mergedStep 1 — Code reviewThe PR bumps Step 2 / Step 3 — Regression verification & CIThe required Root cause: MikroORM enforces at runtime ( Confirmed the fix locally: bumping All other checks (CodeQL, Analyze, dependency audit, gitleaks, Trivy, gate-integrity) passed. Step 4 — MergeNot merged. Per fail-fast policy, the required Verify job is red and merging would break agent sessions on Recommended path
I have not modified the branch. Generated by Claude Code |
Automated Dependabot review — ⛔ blocked at regression verificationStep 1 — Code review
Step 2 — Regression verification: FAILED ❌CI MikroORM enforces that every Isolation (same Node 22, only the dependency changed):
Because Decision — fail-fast: not mergingPer the review policy, a failed regression step stops the pipeline before merge. This PR is not safe to merge as-is. Recommended resolution
Since option 1 adds a production-dependency change beyond this PR's stated scope, it's left to a maintainer's decision rather than amended automatically here. Reviewed by an automated agent. CI run: Generated by Claude Code |
e25faa1 to
3095c6f
Compare
Automated dependency reviewChange: Step 1 — Code reviewThe diff is confined to Step 2 — Regression verification ❌The With Decision — not merged (fail-fast)This bump cannot be merged in isolation. Generated by Claude Code |
Bumps [@mikro-orm/sqlite](https://github.com/mikro-orm/mikro-orm) from 6.6.14 to 6.6.15. - [Release notes](https://github.com/mikro-orm/mikro-orm/releases) - [Changelog](https://github.com/mikro-orm/mikro-orm/blob/v6.6.15/CHANGELOG.md) - [Commits](mikro-orm/mikro-orm@v6.6.14...v6.6.15) --- updated-dependencies: - dependency-name: "@mikro-orm/sqlite" dependency-version: 6.6.15 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
3095c6f to
f5dd747
Compare
Automated dependency review — ⛔ held, not mergedStep 1 — Code review
Step 2 — Regression verification — FAILED Root cause: MikroORM enforces at runtime that every Decision (fail-fast): not merging. This PR cannot be merged in isolation. The correct fix is a grouped bump that moves Generated by Claude Code |
Automated Dependabot review —
|
|
·@·d·ependabot r·ebase Generated by Claude Code |
Automated Dependabot review — ❌ blocked (fail-fast)Step 1 — Code review Step 2 — Regression verification: FAILED MikroORM enforces that every Step 4 — Decision: not merging. Generated by Claude Code |
Automated Dependabot review — ⛔ blocked, not mergedStep 1 — Code review Step 2/3 — Regression / CI verification (fail-fast) Because the agent's ADK
This is a genuine incompatibility that would break the running agent, not just the tests. Step 4 — Decision: Per fail-fast policy, not merged. Suggested remediation (for a maintainer):
The other open dependency PRs have been processed independently. Generated by Claude Code |
Correction & final decision — ⛔ not mergingThe fresh CI run against current Root cause. This PR bumps Required resolution (maintainer action): bump Decision: Not merging (fail-fast). Leaving the PR open for the Generated by Claude Code |
|
A newer version of @mikro-orm/sqlite exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
Automated Dependabot review — ❌ blocked, not mergingStep 1 — Code review Step 2 / 3 — Regression & CI
Step 4 — Decision Generated by Claude Code |
Automated dependency review — ❌ blocked (not merged)Step 1 — Code review
Step 2 — Regression verification: FAILED This throws inside Decision (fail-fast): Not merging. This is not flaky — re-running will not help. The fix is to bump Automated review; CI status was already red on the current head ( Generated by Claude Code |
Dependabot review —
|
Automated Dependabot reviewStep 1 — Code review
Steps 2 & 3 — Regression / CI
Step 4 — Decision: not merged. Per fail-fast, I am not merging a branch that is behind and whose checks are stale. It needs a rebase, after which the shared base-branch vulnerability triage (see #161–#165) also applies. The bump itself is a low-risk patch. Generated by Claude Code |
|
Automated Dependabot review — Code review: Regression verification: ❌ fails. The required Decision: not merging. This needs Generated by Claude Code |
Automated Dependabot review — ⛔ not merging (fail-fast)I rebased this branch onto the latest Step 1 — Code reviewThe version bump itself ( Step 2/3 — Verification & CI (fresh run on the rebased branch)
Step 4 — MergeNot merging. Per fail-fast, the failing required checks stop the process here. Recommended follow-up
Generated by Claude Code |
Automated Dependabot review — ❌ not mergingStep 1 (code review) / Step 2 (regression): this bump introduces a real runtime regression, reproduced locally. MikroORM enforces that every
This is the cause of the failing Verify (typecheck + coverage + build + e2e) check on this PR. Step 3 (CI): in addition to the above, the required Dependency audit (prod, high+) and Container scan (trivy) checks are red repo-wide (pre-existing transitive vulns / base-image CVEs, unrelated to this bump). Decision: not merged. A lone Generated by Claude Code |
Automated Dependabot review — not merged (fail-fast) ❌Scope: Blocking finding (Step 2 — regression): the required Verify check fails — MikroORM enforces that every official The sidecar's ADK Recommended resolution: bump the whole Generated by Claude Code |
Bumps @mikro-orm/sqlite from 6.6.14 to 6.6.15.
Release notes
Sourced from @mikro-orm/sqlite's releases.
Changelog
Sourced from @mikro-orm/sqlite's changelog.
Commits
7b194c2chore(release): v6.6.15 [skip ci]96e2f0ftest: cover multi-element array operator nested under a relation (#7901)6040aa1fix(knex): resolve target entity schema in nested collection operators (#7898)49d73a5fix(core): avoid crash on STI subclass narrowing an inverse collection (#7868)a3db208fix(core): avoid stack overflow in IdentityMap.keys()/values() for large maps...5c5e4c9fix(core): preserve sibling conditions next to$and/$oron relation filte...65e1967fix(core): reload suppressed entities from partially-suppressed upsertMany (#...3e50f3achore(ci): stop tagging v6 releases aslatest(#7666)4ece4fachore(release): update internal dependencies [skip ci]Most Recent Ignore Conditions Applied to This Pull Request