Skip to content

ci: add workspace test gate (fmt, clippy, cargo test)#19

Open
BunsDev wants to merge 1 commit into
mainfrom
ci/workspace-test-gate
Open

ci: add workspace test gate (fmt, clippy, cargo test)#19
BunsDev wants to merge 1 commit into
mainfrom
ci/workspace-test-gate

Conversation

@BunsDev

@BunsDev BunsDev commented Jul 21, 2026

Copy link
Copy Markdown
Member

Summary

Adds the missing automated test gate. Every PR and push to main now runs:

  • cargo fmt --all --check
  • cargo clippy --workspace --all-targets -- -D warnings
  • cargo test --workspace — the full 98+ test suite, including the RFC-0001 §5 conformance tests and C7 round-trip tests

Why

Observed during the 2026-07-21 state review: all five open Phase 5 PRs show zero status checks — the repo had no CI at all. For a layer whose identity is fail-closed enforcement, PRs merging with no automated gate is the same failure shape the layer exists to prevent. This closes it with the minimal standard workflow (checkout@v4, dtolnay/rust-toolchain@stable, Swatinem/rust-cache@v2, read-only permissions).

Verification

cargo test --workspace ran green locally on main (6476a67) this morning before branching; this workflow adds no code changes.


Opened by Echo 🪞 under Val's "proceed with what's best" direction, 2026-07-21. Review + merge is Val/Nova's call — merging this first gives every Phase 5 PR a real check before the stack lands.

Every PR and push to main now runs the full workspace suite —
including the RFC-0001 §5 conformance tests and C7 round-trip
tests — plus rustfmt and clippy with warnings denied.

Closes the observed gap: a fail-closed enforcement layer had no
automated test gate on its own PRs.
Copilot AI review requested due to automatic review settings July 21, 2026 13:28

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a baseline GitHub Actions CI workflow to enforce Rust workspace quality gates on every PR and on pushes to main, aligning the repo’s “fail-closed enforcement” goals with automated checks.

Changes:

  • Introduces a new CI workflow triggered on pull_request and push to main.
  • Runs cargo fmt --all --check, cargo clippy --workspace --all-targets -- -D warnings, and cargo test --workspace on ubuntu-latest.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/ci.yml
Comment on lines +23 to +26
- name: Clippy
run: cargo clippy --workspace --all-targets -- -D warnings
- name: Tests
run: cargo test --workspace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants