Skip to content

fix: inject BOOTIF kernel param from requesting MAC at bootscript serve time #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexlovelltroy merged 2 commits into from
Jun 4, 2026
+114 −1
Merged

fix: inject BOOTIF kernel param from requesting MAC at bootscript serve time #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd5752e
fix: inject BOOTIF kernel param from requesting MAC at bootscript ser…
j0hnL May 26, 2026
ceb3bd8
test: add BOOTIF injection tests for various MAC address scenarios
alexlovelltroy Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion cmd/boot-script-service/default_api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ type scriptParams struct {
xname string
nid string
referralToken string
mac string
}

// Note that we allow an empty string if the env variable is defined as such.
Expand Down Expand Up @@ -689,6 +690,11 @@ func buildParams(bd BootData, sp scriptParams, role, subRole string) (string, er
if sp.referralToken != "" {
params = checkParam(params, "bss_referral_token=", sp.referralToken)
}
// Add BOOTIF to params to force 1st mac
if sp.mac != "" {
bootif := "01-" + strings.ReplaceAll(sp.mac, ":", "-")
params = checkParam(params, "BOOTIF=", bootif)
}

// Inject the cloud init address info into the kernel params. If the target
// image does not have cloud-init enabled this wont hurt anything.
Expand Down Expand Up @@ -841,7 +847,7 @@ func BootscriptGet(w http.ResponseWriter, r *http.Request) {
log.Printf("BSS request failed: bootscript request without mac=, name=, or nid= parameter")
return
}
sp := scriptParams{comp.ID, comp.NID.String(), bd.ReferralToken}
sp := scriptParams{comp.ID, comp.NID.String(), bd.ReferralToken, mac}

debugf("bd: %v\n", bd)
debugf("comp: %v\n", comp)
Expand Down
107 changes: 107 additions & 0 deletions cmd/boot-script-service/default_api_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,113 @@ func TestBuildParams_Success(t *testing.T) {
"nid=0",
fmt.Sprintf("ds=nocloud-net;s=%s/", advertiseAddress),
}},
{
// BOOTIF injection with MAC address
BootData{
Params: "root=nfs:example/path/to/rootfs:ro",
Kernel: ImageData{Path: "http://example/path/to/vmlinuz"},
Initrd: ImageData{Path: "http://example/path/to/initramfs.img"},
},
scriptParams{
xname: "x0000c0s0b0n0",
nid: "0",
mac: "aa:bb:cc:dd:ee:ff",
},
[]string{
"initrd=initrd",
"root=nfs:example/path/to/rootfs:ro",
"xname=x0000c0s0b0n0",
"nid=0",
"BOOTIF=01-aa-bb-cc-dd-ee-ff",
fmt.Sprintf("ds=nocloud-net;s=%s/", advertiseAddress),
},
},
{
// No BOOTIF injection when mac is empty
BootData{
Params: "root=nfs:example/path/to/rootfs:ro",
Kernel: ImageData{Path: "http://example/path/to/vmlinuz"},
Initrd: ImageData{Path: "http://example/path/to/initramfs.img"},
},
scriptParams{
xname: "x0000c0s0b0n0",
nid: "0",
mac: "",
},
[]string{
"initrd=initrd",
"root=nfs:example/path/to/rootfs:ro",
"xname=x0000c0s0b0n0",
"nid=0",
fmt.Sprintf("ds=nocloud-net;s=%s/", advertiseAddress),
},
},
{
// Existing BOOTIF in params is preserved (not overwritten)
BootData{
Params: "root=nfs:example/path/to/rootfs:ro BOOTIF=01-11-22-33-44-55-66",
Kernel: ImageData{Path: "http://example/path/to/vmlinuz"},
Initrd: ImageData{Path: "http://example/path/to/initramfs.img"},
},
scriptParams{
xname: "x0000c0s0b0n0",
nid: "0",
mac: "aa:bb:cc:dd:ee:ff",
},
[]string{
"initrd=initrd",
"root=nfs:example/path/to/rootfs:ro",
"BOOTIF=01-11-22-33-44-55-66",
"xname=x0000c0s0b0n0",
"nid=0",
fmt.Sprintf("ds=nocloud-net;s=%s/", advertiseAddress),
},
},
{
// BOOTIF with uppercase MAC address
BootData{
Params: "root=nfs:example/path/to/rootfs:ro",
Kernel: ImageData{Path: "http://example/path/to/vmlinuz"},
Initrd: ImageData{Path: "http://example/path/to/initramfs.img"},
},
scriptParams{
xname: "x0000c0s0b0n0",
nid: "0",
mac: "AA:BB:CC:DD:EE:FF",
},
[]string{
"initrd=initrd",
"root=nfs:example/path/to/rootfs:ro",
"xname=x0000c0s0b0n0",
"nid=0",
"BOOTIF=01-AA-BB-CC-DD-EE-FF",
fmt.Sprintf("ds=nocloud-net;s=%s/", advertiseAddress),
},
},
{
// BOOTIF with all parameters (mac, referralToken, kernel params)
BootData{
Params: "root=nfs:example/path/to/rootfs:ro",
Kernel: ImageData{Path: "http://example/path/to/vmlinuz", Params: "console=ttyS0"},
Initrd: ImageData{Path: "http://example/path/to/initramfs.img"},
},
scriptParams{
xname: "x0000c0s0b0n0",
nid: "0",
referralToken: "test_token",
mac: "00:11:22:33:44:55",
},
[]string{
"initrd=initrd",
"root=nfs:example/path/to/rootfs:ro",
"console=ttyS0",
"xname=x0000c0s0b0n0",
"nid=0",
"bss_referral_token=test_token",
"BOOTIF=01-00-11-22-33-44-55",
fmt.Sprintf("ds=nocloud-net;s=%s/", advertiseAddress),
},
},
}

for _, tc := range test_cases {
Expand Down
Loading