Feature/boot profile clarification#10
Merged
Merged
Conversation
…ocumentation Signed-off-by: Alex Lovell-Troy <alovelltroy@lanl.gov> Signed-off-by: Alex Lovell-Troy <alex@lovelltroy.org>
…guration across profiles Signed-off-by: Alex Lovell-Troy <alovelltroy@lanl.gov> Signed-off-by: Alex Lovell-Troy <alex@lovelltroy.org>
… ignore profile query parameter Signed-off-by: Alex Lovell-Troy <alovelltroy@lanl.gov> Signed-off-by: Alex Lovell-Troy <alex@lovelltroy.org>
…proved clarity and maintainability Signed-off-by: Alex Lovell-Troy <alex@lovelltroy.org>
…kflow Signed-off-by: Alex Lovell-Troy <alex@lovelltroy.org>
…nerate code comments Signed-off-by: Alex Lovell-Troy <alex@lovelltroy.org>
… output Signed-off-by: Alex Lovell-Troy <alex@lovelltroy.org>
Signed-off-by: Alex Lovell-Troy <alex@lovelltroy.org>
…ions Signed-off-by: Alex Lovell-Troy <alex@lovelltroy.org>
…0ddd6b Signed-off-by: Alex Lovell-Troy <alex@lovelltroy.org>
… in go.mod Co-authored-by: Copilot <copilot@github.com> Signed-off-by: Alex Lovell-Troy <alex@lovelltroy.org>
Signed-off-by: Alex Lovell-Troy <alex@lovelltroy.org>
Co-authored-by: Copilot <copilot@github.com> Signed-off-by: Alex Lovell-Troy <alex@lovelltroy.org>
…custom OpenAPI extension support Signed-off-by: Alex Lovell-Troy <alex@lovelltroy.org>
Co-authored-by: Copilot <copilot@github.com> Signed-off-by: Alex Lovell-Troy <alex@lovelltroy.org>
… usage Co-authored-by: Copilot <copilot@github.com> Signed-off-by: Alex Lovell-Troy <alex@lovelltroy.org>
Signed-off-by: Alex Lovell-Troy <alex@lovelltroy.org>
Signed-off-by: Alex Lovell-Troy <alex@lovelltroy.org>
Signed-off-by: Alex Lovell-Troy <alex@lovelltroy.org>
655040d to
41c6add
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates the boot configuration selection logic to allow profile-less (empty profile) boot requests to select the best matching configuration across all profiles, rather than defaulting to the "default" profile. The changes also clarify the intended behavior for default/catch-all configurations, improve deterministic selection among candidates, and update tests to reflect the new logic.
Boot configuration selection logic:
Validation and documentation:
BootConfigurationhas been removed, allowing for catch-all default configurations. Documentation comments clarify that this is intentional for supporting default profiles. [1] [2]Deterministic candidate selection:
Test updates:
Checklist
make test(or equivalent) locally and all tests passgit commit -s) with my real name and email<filename>.licensesidecarLICENSES/directoryType of Change
For more info, see Contributing Guidelines.