Skip to content

Feature/boot profile clarification#10

Merged
alexlovelltroy merged 19 commits into
mainfrom
feature/boot-profile-clarification
May 5, 2026
Merged

Feature/boot profile clarification#10
alexlovelltroy merged 19 commits into
mainfrom
feature/boot-profile-clarification

Conversation

@alexlovelltroy

Copy link
Copy Markdown
Member

Description

This pull request updates the boot configuration selection logic to allow profile-less (empty profile) boot requests to select the best matching configuration across all profiles, rather than defaulting to the "default" profile. The changes also clarify the intended behavior for default/catch-all configurations, improve deterministic selection among candidates, and update tests to reflect the new logic.

Boot configuration selection logic:

  • Profile-less boot requests now select the best matching configuration across all profiles, using score and priority, instead of always defaulting to the "default" profile. This allows more specific or higher-priority configurations from any profile to be chosen when no profile is specified. [1] [2]

Validation and documentation:

  • The requirement for at least one targeting method (hosts, macs, nids, or groups) in BootConfiguration has been removed, allowing for catch-all default configurations. Documentation comments clarify that this is intentional for supporting default profiles. [1] [2]

Deterministic candidate selection:

  • When selecting among multiple matching boot configurations, candidates are now sorted by score (descending), then priority (descending), and then name (ascending) to ensure deterministic selection when score and priority are identical.

Test updates:

  • Unit and handler tests have been updated to verify that empty or missing profile requests select the best matching configuration across all profiles, not just the "default" profile. New tests cover priority-based selection across profiles. [1] [2] [3] [4] [5] [6]

Checklist

  • My code follows the style guidelines of this project
  • I have added/updated comments where needed
  • I have added tests that prove my fix is effective or my feature works
  • I have run make test (or equivalent) locally and all tests pass
  • DCO Sign-off: All commits are signed off (git commit -s) with my real name and email
  • REUSE Compliance:
    • Each new/modified source file has SPDX copyright and license headers
    • Any non-commentable files include a <filename>.license sidecar
    • All referenced licenses are present in the LICENSES/ directory

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

For more info, see Contributing Guidelines.

alexlovelltroy and others added 19 commits May 5, 2026 12:25
…ocumentation

Signed-off-by: Alex Lovell-Troy <alovelltroy@lanl.gov>
Signed-off-by: Alex Lovell-Troy <alex@lovelltroy.org>
…guration across profiles

Signed-off-by: Alex Lovell-Troy <alovelltroy@lanl.gov>
Signed-off-by: Alex Lovell-Troy <alex@lovelltroy.org>
… ignore profile query parameter

Signed-off-by: Alex Lovell-Troy <alovelltroy@lanl.gov>
Signed-off-by: Alex Lovell-Troy <alex@lovelltroy.org>
…proved clarity and maintainability

Signed-off-by: Alex Lovell-Troy <alex@lovelltroy.org>
…kflow

Signed-off-by: Alex Lovell-Troy <alex@lovelltroy.org>
…nerate code comments

Signed-off-by: Alex Lovell-Troy <alex@lovelltroy.org>
… output

Signed-off-by: Alex Lovell-Troy <alex@lovelltroy.org>
Signed-off-by: Alex Lovell-Troy <alex@lovelltroy.org>
…ions

Signed-off-by: Alex Lovell-Troy <alex@lovelltroy.org>
…0ddd6b

Signed-off-by: Alex Lovell-Troy <alex@lovelltroy.org>
… in go.mod

Co-authored-by: Copilot <copilot@github.com>
Signed-off-by: Alex Lovell-Troy <alex@lovelltroy.org>
Signed-off-by: Alex Lovell-Troy <alex@lovelltroy.org>
Co-authored-by: Copilot <copilot@github.com>
Signed-off-by: Alex Lovell-Troy <alex@lovelltroy.org>
…custom OpenAPI extension support

Signed-off-by: Alex Lovell-Troy <alex@lovelltroy.org>
Co-authored-by: Copilot <copilot@github.com>
Signed-off-by: Alex Lovell-Troy <alex@lovelltroy.org>
… usage

Co-authored-by: Copilot <copilot@github.com>
Signed-off-by: Alex Lovell-Troy <alex@lovelltroy.org>
Signed-off-by: Alex Lovell-Troy <alex@lovelltroy.org>
Signed-off-by: Alex Lovell-Troy <alex@lovelltroy.org>
Signed-off-by: Alex Lovell-Troy <alex@lovelltroy.org>
@alexlovelltroy alexlovelltroy force-pushed the feature/boot-profile-clarification branch from 655040d to 41c6add Compare May 5, 2026 11:26
@alexlovelltroy alexlovelltroy merged commit 4962568 into main May 5, 2026
6 checks passed
@synackd synackd deleted the feature/boot-profile-clarification branch May 5, 2026 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant