Add podman support and registry login to container scripts#3497
Open
mcosgriff wants to merge 7 commits into
Open
Add podman support and registry login to container scripts#3497mcosgriff wants to merge 7 commits into
mcosgriff wants to merge 7 commits into
Conversation
…ipts Replace hard-coded docker references with cached runtime detection that supports both docker and podman, including their compose variants. Add registry_login to run/build commands to avoid 403 errors when pulling images. Matching logic applied to both sh and bat scripts. Co-Authored-By: Claude noreply@anthropic.com
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3497 +/- ##
==========================================
- Coverage 79.32% 79.29% -0.04%
==========================================
Files 670 689 +19
Lines 56846 57334 +488
Branches 728 728
==========================================
+ Hits 45095 45463 +368
- Misses 11673 11793 +120
Partials 78 78
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Use modern $() syntax instead of backticks for pwd in cli and cliroot volume mount arguments for consistency and readability.
…heck-if-logged-into-container-registry
Add registry authentication checks to avoid overwriting valid stored credentials with stale environment variables. In openc3_build_ubi.sh, use docker manifest inspect to verify access before attempting login. In openc3.sh, check Docker/Podman config files for existing credentials. Rescue Redis connection errors in StoreQueued shutdown to prevent CI test failures when Redis is unavailable during process exit.
…ariable' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
jmthomas
previously approved these changes
Jun 27, 2026
jmthomas
left a comment
Member
There was a problem hiding this comment.
I made equivalent change to store_queued.py. This change forced me to login to docker.io during the build but I think that's ok. I previously was building fine without this login.
jmthomas
approved these changes
Jun 27, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
DockerandPodman(including podman compose and podman-compose variants)run,run-ubi, andbuildcommands to avoid 403 errors when pulling images — logs intoOPENC3_REGISTRY(core) andOPENC3_ENTERPRISE_REGISTRY(enterprise) using interactive credentialsopenc3.shandopenc3.batChanges
openc3.shdockerorpodman${DOCKER_COMPOSE_COMMAND}references replaced with${CONTAINER_CMD}and${CONTAINER_COMPOSE_CMD}openc3.bat:registry_loginsubroutine with matching logicscripts/linux/openc3_test.shDOCKER_COMPOSE_COMMANDfrom parent if available, otherwise detects runtime with podman supportscripts/linux/openc3_util.shopenc3/lib/openc3/utilities/store_queued.rbprocess_queue()call inshutdownwith a rescue block. This fixes the CI failure where all tests pass but theat_exithook raisesRedis::CannotConnectErrorwhen Redis is unavailable during process shutdown, causing exit code 1.Closes #3497