Conversation
PluginModel.install_phase2 interpolated the user-writable pypi_url setting into a shell command run through a backtick, allowing arbitrary OS command execution during plugin install. Run pipinstall via an argv array with Open3.capture2e (no shell) and validate pypi_url is an http(s) URL at use-time, falling back to the default on a bad value. Add a shared PypiUrl utility and spec. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3489 +/- ##
==========================================
- Coverage 79.25% 79.23% -0.02%
==========================================
Files 689 690 +1
Lines 57293 57306 +13
Branches 728 728
==========================================
+ Hits 45406 45408 +2
- Misses 11809 11820 +11
Partials 78 78
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mcosgriff
approved these changes
Jun 18, 2026
mcosgriff
left a comment
mcosgriff
left a comment
Contributor
There was a problem hiding this comment.
Tests pass locally, looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PluginModel.install_phase2 interpolated the user-writable pypi_url setting into a shell command run through a backtick, allowing arbitrary OS command execution during plugin install. Run pipinstall via an argv array with Open3.capture2e (no shell) and validate pypi_url is an http(s) URL at use-time, falling back to the default on a bad value. Add a shared PypiUrl utility and spec.
🤖 Generated with Claude Code