Retry transient shared contact profile downloads - #251
Closed
Xare123 wants to merge 2 commits into
Closed
Conversation
Author
|
Superseded by #250. The send and shared-profile retry changes both modify the same RustPush service lifecycle and conflict when merged independently, so they were combined into one tested review unit. The combined policy suite passes 9 of 9 focused tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Temporary relay or network failures should not permanently prevent a shared contact profile from loading, while malformed or permanent failures should not retry forever.
Validation
Scope
The retry policy is limited to shared contact profile downloads.