Skip to content

fix(ui): allow web search tests to use env keys#280

Open
snvtac wants to merge 1 commit into
OpenBMB:mainfrom
snvtac:snvtac/254-web-search-settings-env-keys
Open

fix(ui): allow web search tests to use env keys#280
snvtac wants to merge 1 commit into
OpenBMB:mainfrom
snvtac:snvtac/254-web-search-settings-env-keys

Conversation

@snvtac

@snvtac snvtac commented Jun 24, 2026

Copy link
Copy Markdown

Summary

  • let the Settings web-search test route resolve provider keys the same way runtime does: inline key first, then provider-specific env/customEnv fallbacks
  • allow the Settings Test button to run without an inline API key and send the current customEnv form state to the backend
  • preserve masked saved customEnv secrets without reviving keys removed from the current form
  • update Settings copy and add targeted backend/frontend regression coverage

Validation

  • pnpm --dir ui exec vitest run server/routes/config.test.js src/components/settings/view/tabs/PilotDeckConfigTab.webSearch.test.ts
  • pnpm --dir ui exec eslint src/components/settings/view/tabs/PilotDeckConfigTab.tsx src/components/settings/view/tabs/pilotDeckConfigForm.ts src/components/settings/view/tabs/PilotDeckConfigTab.webSearch.test.ts (passes with one existing warning in PilotDeckConfigTab.tsx)
  • node --check ui/server/routes/config.js && node --check ui/server/routes/config.test.js
  • git diff --check

Notes

Full pnpm --dir ui run typecheck still fails on existing repo-wide React/lucide type conflicts and unrelated TS errors. Full pnpm --dir ui run lint still fails on existing unrelated lint errors in chat/WebSocket/session tests; the touched Settings files have no new lint errors.

Closes #254

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(web-search): Settings test rejects env-provided API keys that runtime accepts

1 participant