feat(etl): port handle_comment/event/share triggers (parity 1D)#241
Open
raymondjacobson wants to merge 1 commit intoetl/parity-1c-content-triggersfrom
Open
feat(etl): port handle_comment/event/share triggers (parity 1D)#241raymondjacobson wants to merge 1 commit intoetl/parity-1c-content-triggersfrom
raymondjacobson wants to merge 1 commit intoetl/parity-1c-content-triggersfrom
Conversation
Stack 1D of the trigger-port plan. Migration 0020 adds aggregate columns
and ports three of apps' four secondary triggers:
- aggregate_track.{comment_count,share_count} (apps#0145)
- aggregate_playlist.share_count
- aggregate_user.track_share_count
- handle_comment: maintains aggregate_track.comment_count.
- handle_event: creates fan_remix_contest_started notifications for
followers + favoriters when a remix_contest event is added on a public
track.
- handle_share: maintains aggregate_track.share_count or
aggregate_playlist.share_count and aggregate_user.track_share_count.
Skipped: handle_supporter_rank_up depends on user_bank_txs and
supporter_rank_ups tables which are part of the Solana indexer (out of
scope per parity plan).
Three DB-backed tests verify comment_count tick, share_count tick on track,
and fan_remix_contest_started fan-out notification on event insert.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stack 1D of the trigger-port plan. Migration 0020 adds:
Skipped
`handle_supporter_rank_up` is intentionally not ported. It depends on `user_bank_txs` and `supporter_rank_ups` tables which are part of the Solana indexer (explicitly out of scope per the parity plan).
Stack context
Stacked on #240 (1C — content triggers).
Test plan
Three DB-backed tests in secondary_triggers_test.go:
🤖 Generated with Claude Code