issue#130- Update login attribution to Maintained by Open Source Kigali - #139
Merged
Merged
Conversation
rodriguecyber
approved these changes
Aug 21, 2026
rodriguecyber
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The auth pages attributed the project to "Open Source Kigali". They now read
"Maintained by Open Source Kigali", and the attribution renders at every
breakpoint instead of desktop only.
The mobile gap
The attribution lived in the brand
<aside>, which ishidden ... lg:flex— sobelow
lgthat element is not in the tree at all and mobile showed noattribution. Satisfying "visible and readable on desktop and mobile layouts"
needed more than a string change:
MAINTAINER_ATTRIBUTIONholds the wording in one placelg:hiddenline below the form card renders it on mobileLoginPageandSetupPageboth render throughAuthLayout, so both pick thisup without a second copy of the string.
The mobile placement mirrors the compact brand row already in the same file,
which uses
lg:hiddenfor exactly this desktop/mobile split.Acceptance criteria
Testing
npm run lint— no new warnings (3 pre-existing inErrorBoundary.tsx,button.tsx,ToastProvider.tsx)npm test— 44 passed across 3 filesnpm run build—tsc -b && vite buildclean/loginand/setup, above and below thelgbreakpointOn the test criterion
The issue asks for a focused test if the auth layout is covered by tests. It
isn't — the existing suites are
lib/format.test.ts,lib/metrics.test.ts, andstores/auth.test.ts, all pure logic. There's no@testing-library/react, nojsdom/happy-dom, and no
testblock invite.config.ts. Standing up componenttesting felt outside this issue's "frontend branding only" scope, so I left it
out deliberately. Happy to add that infrastructure in a separate PR if you want
AuthLayoutcovered.Closes #130

