fix(cli): verify SHA-256 of downloaded release assets - #109
Merged
rodriguecyber merged 1 commit intoAug 17, 2026
Merged
Conversation
Publish checksums.txt with each release. Compare the downloaded file before installing to /usr/local/bin. Missing checksums on older releases is a warning, not a hard failure. Truncated downloads that do not match Asset.Size are rejected. Fixes Open-Source-Kigali#22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The CLI downloads a binary and installs it as root with no check that the bytes match what was published. TLS only covers transit.
Changes
scripts/build-release.shwritessha256sum docksight-* > checksums.txtscripts/publish-release.shrequireschecksums.txtamong expected assetsrelease.Client.VerifyDownloadedfetches checksums.txt, hashes the file, aborts on mismatchDownloadnow compares written bytes toAsset.Sizeand deletes a truncated fileselfinstall.InstallTest plan
go test ./cmd/internal/release/ ./cmd/internal/installer/ ./cmd/internal/agent/install/Fixes #22