test: handle quoted Windows config paths - #102
Merged
rodriguecyber merged 1 commit intoAug 11, 2026
Merged
Conversation
Contributor
Author
|
@rodriguecyber The focused fix for #99 is ready at one current test-only commit. The synthetic backslash path reproduced the exact failure on macOS before the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keeps the existing
%qpath formatting and updatesTestLoadServerURLto require the correspondingstrconv.Quote(path)representation. Quoted paths retain the useful visibility of whitespace and control characters while making the assertion correct on Windows.On non-Windows systems, the test now uses a valid filename containing a literal backslash. That reproduces the Windows escaping mismatch in every local and hosted run instead of relying on the runner OS to expose it.
Type of change
Areas touched
apps/server(NestJS)apps/web(React / Vite)apps/agent(Go)packages/protocol(shared WebSocket contracts)infrastructure/.github/workflowsdocsRelated issues
Closes #99
How to test
cd apps/agentgo test ./internal/config/ -run TestLoadServerURL -count=1 -vgo test ./...The synthetic backslash path produced the issue's exact RED failure before the assertion change. The final complete agent suite also passes on
windows-latestin an isolated fork-only validation run: https://github.com/floze-the-genius/docksight/actions/runs/31455527967Checklist
Local verification: focused RED/GREEN regression, full
go test ./...,go vet ./...,go build ./...,go mod tidydrift check, all four release-target cross-compiles, Windows test-binary cross-compile, andgit diff --check.Protocol changes
Not applicable;
packages/protocolis untouched.Screenshots
Not applicable; no UI change.