spring: Add OAuth + student ID verified password reset flow (2/4 split of #168) - #170
Open
RudraBJoshi wants to merge 5 commits into
Open
Conversation
FlaskPasswordSync calls Flask's internal sync endpoint (POST /api/internal/sync-password) with a shared secret (INTERNAL_SYNC_KEY), so a password reset completed on Spring also lands on the Flask account for the same uid. Not wired up to any caller yet -- that's the OAuth-verified reset flow, next PR in the stack. Best-effort: a sync failure is logged, not fatal to whatever already-successful operation triggered it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
New security-driven self-service reset: a student proves account ownership by signing in with their @stu.powayusd.com school Google account, and the trailing 5 digits of that (server-verified) email must match the last 5 digits of the account's stored sid before a reset is allowed. GoogleIdTokenVerifier verifies the Google Identity Services ID token server-side via Google's tokeninfo endpoint (checks aud, iss, email_verified) -- the existing signup flow only ever decoded this token client-side and never verified it, fine as a UX nicety but not acceptable as an actual security gate. POST /mvc/person/reset/oauth/verify reuses the admin/default-account guards and rate limiting from the existing email-based /reset/start flow, and on success issues a single-use token via the existing ResetCode infrastructure. POST /mvc/person/reset/oauth/complete spends that token and sets the new password, then best-effort syncs it to Flask via FlaskPasswordSync (added in the previous PR in this stack). Also invalidates JWTs when a password changes (Person.tokenVersion, bumped in PersonDetailsService.save whenever samePassword is false; JwtTokenUtil stamps and checks it), fixes ResetCode's RESET_TOKEN_SECRET resolution so it actually sees Spring's .env-imported value instead of silently signing tokens with a random per-restart key, and repoints login.html's "Forgot Password?" link at the new verified reset wizard on the pages site. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Hook Person.checkPassword() (8+ chars, upper/lower/digit/special) into PersonDetailsService.save(), guarded so unrelated profile edits that re-save an existing password hash aren't re-validated. Check complexity in /reset/oauth/complete before consuming the reset token. Fix two non-compliant default-password fallback literals that would otherwise break seed init and reset-to-default once complexity is enforced. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Addresses jm1021's review feedback on this PR/flask Open-Coding-Society#74 ("tied to Profile Password reset") reinterpreted for the current architecture: the profile page's direct password field was removed in a later PR in the same stack in favor of routing everyone through this OAuth wizard, so "tied to profile reset" now means "tied to the wizard's completion". Track MVC logins in a SessionRegistry (tracking only, no session cap) and force-expire a uid's sessions after /reset/oauth/complete succeeds, closing the previously-documented gap where the JWT path invalidated on password change but the MVC HttpSession path didn't. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Route the unknown-uid (was 204) and admin/default-account (was 401) denial paths in /reset/oauth/verify through the same oauthResetDenied() helper as every other check, so they're no longer distinguishable from a real failed verification by status code or body shape. 429 (rate limit) still necessarily differs -- the frontend needs it to show "Request a Ticket Instead". Also add rel="noopener noreferrer" to this file's two target="_blank" links (unrelated pre-existing template code, general hygiene). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splitting #168 into smaller, independently-reviewable PRs across spring/flask/pages. This one covers the password reset button — the core verified reset mechanism.
Depends on #169 (merge that first) — this branch includes #169's
FlaskPasswordSynccommit since GitHub can't base a PR on a branch that only exists in this fork. Once #169 merges, this diff will shrink to just this PR's own changes.New security-driven self-service reset: a student proves account ownership by signing in with their @stu.powayusd.com school Google account, and the trailing 5 digits of that (server-verified) email must match the last 5 digits of the account's stored sid before a reset is allowed.
GoogleIdTokenVerifierverifies the Google Identity Services ID token server-side via Google's tokeninfo endpoint — the existing signup flow only ever decoded it client-side.POST /mvc/person/reset/oauth/verify/POST /mvc/person/reset/oauth/completeimplement the two-step verify-then-set-password flow, reusing the existingResetCodeinfrastructure. Completion best-effort syncs to Flask viaFlaskPasswordSync(spring: Add Flask password-sync utility (1/4 split of #168) #169).Person.tokenVersion, bumped on any password-change path).ResetCode'sRESET_TOKEN_SECRETresolution so it actually sees Spring's.env-imported value instead of silently signing tokens with a random per-restart key.login.html's "Forgot Password?" link at the new verified wizard on the pages site.Original PR: #168