Code Runner Preliminary Containerization - #77
Open
mataiodoxion wants to merge 6 commits into
Open
Conversation
as per Mr. Mort, we don't need the security layer in local development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runs the python code execution endpoint in a separate container if
.envkeyIS_PRODUCTION=true, otherwise just runs the exec locally.This fixes the main issue with reading sensitive contents of the main
flask-webcontainer like sending:{ "code": "import os; os.system('cat /app/.env')" }which is now just met with (because it's a different container)
{ "output": "cat: /app/.env: No such file or directory\n" }It might be beneficial to work on some more container hardening (especially for the kernel to prevent escapes), and setting limits for resource exhaustion, but this fixes the most glaring issues for now.