Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/agent-harness/knowhere-text.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,11 @@ describe("knowhereToolText", () => {
expect(text).toContain('<knowhere operation="search" status="ok">')
expect(text).toContain('ref="r1:result:1"')
expect(text).toContain('ref="asset:r1:result:1"')
expect(text).toContain("Page one summary.")
expect(text).toContain("Call inspectImage")
expect(text).toContain("before finalize")
expect(text).not.toContain("<evidence>")
expect(text).not.toContain("Page one evidence.")
expect(text).not.toContain("https://assets.example/page-1.png")
})

Expand Down
3 changes: 2 additions & 1 deletion src/agent-harness/knowhere-text.ts
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,8 @@ export const knowhereToolText = {
stopReason: input.response.stopReason ?? undefined,
failureReason: input.response.failureReason ?? undefined,
}),
formatOptionalTextTag("evidence", input.response.evidenceText),
// Model grounding comes from <chunks> (results). Do not also inject
// evidenceText — same bodies, no citeable refs, doubles context.
formatEvidenceChunks(input.chunks),
formatEvidenceAssets(input.assets),
formatAssetInstruction(input.assets),
Expand Down
3 changes: 2 additions & 1 deletion src/agent-harness/runtime.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,8 @@ describe("agent harness runtime", () => {

expect(firstResult).toContain('ref="r1:result:1"')
expect(secondResult).toContain('retrievalCount="2"')
expect(secondResult).toContain("Second evidence")
expect(secondResult).toContain("Second retrieval evidence.")
expect(secondResult).not.toContain("<evidence>")
expect(secondResult).toContain('ref="r2:result:1"')
expect(JSON.stringify(secondResult)).not.toContain("r1:result:1")
expect(ledger.snapshot().chunks.map((chunk) => chunk.ref)).toEqual([
Expand Down
12 changes: 0 additions & 12 deletions src/domains/chat/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,6 @@ export const answerQuestionWithRetrieval = (
results: useNotebookSourceTitles(rawResults, input.sources),
sources: input.sources,
hardenChatAssetUrl: input.hardenChatAssetUrl,
evidenceText: formatRetrievalEvidenceText(retrievalResponses),
}),
)
const pageCitationResults = yield* Effect.tryPromise(() =>
Expand Down Expand Up @@ -1343,17 +1342,6 @@ function hasDisplayedManifestArtifacts(result: HarnessRunResult): boolean {
return result.manifest.artifacts.some((artifact) => artifact.display)
}

function formatRetrievalEvidenceText(
responses: readonly RetrievalQueryResponse[],
): string | undefined {
const evidenceText = responses
.map((response): string => response.evidenceText?.trim() ?? "")
.filter((value): boolean => value.length > 0)
.join("\n")

return evidenceText || undefined
}

function getRetrievalResultKey(result: RetrievalResult): string {
const source = result.source
return [
Expand Down
2 changes: 0 additions & 2 deletions src/domains/chat/media-assets.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,6 @@ describe("chat media assets", () => {
}),
],
hardenChatAssetUrl,
evidenceText:
"[image-6-中华人民共和国居民身份证.jpg]\n[image-7-中国居民身份证.jpg]",
})

expect(results).toHaveLength(1)
Expand Down
1 change: 0 additions & 1 deletion src/domains/chat/media-assets.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ export type RetrievalResultAssetInput = {
readonly results: readonly RetrievalResult[]
readonly sources: readonly Source[]
readonly hardenChatAssetUrl?: HardenChatAssetUrl
readonly evidenceText?: string
}

export async function enrichRetrievalResultsWithAssetUrls({
Expand Down
Loading