feat: re-issue Knowhere service JWTs without a session cookie - #98
Merged
Conversation
Background Notebook workflows cannot call issueServiceJwt, so expired snapshots need a public refresh that still verifies JWKS. Co-authored-by: Cursor <cursoragent@cursor.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
knowhereServiceJwt.refreshso Notebook QStash workflows can re-issue a one-hour Knowhere JWT from a still-signed snapshot (no session cookie).Notebook long parses were dying on the snapshotted 1h JWT (
Authentication required) even when Knowhere later finished successfully. Companion: Ontos-AI/knowhere-notebookfix/suguan/refresh-qstash-knowhere-jwt.Test plan
pnpm testcovers JWKS verification, the seven-day tolerance, and missing user idPOST /api/orpc/knowhereServiceJwt/refreshwith a valid or recently expired service JWT returns a new tokenMade with Cursor