Cancel sidecar parent-block fetches on sync service shutdown - #17462
Open
syjn99 wants to merge 4 commits into
Open
Cancel sidecar parent-block fetches on sync service shutdown#17462syjn99 wants to merge 4 commits into
syjn99 wants to merge 4 commits into
Conversation
- #13061 This PR creates a new context and puts it in `sendBatchRootRequest`. This commit uses more correct context which is a service context, following #17057's choice as well. This commit also registers `stream.Reset()` after the context for two by-root senders. Unit test: `TestValidateSidecar_ParentRequestServiceLifetime`
syjn99
marked this pull request as draft
September 7, 2026 09:00
syjn99
marked this pull request as ready for review
September 7, 2026 09:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
When a blob or data column sidecar arrives over gossip before its parent block, the (blob/data column) validator spawns a goroutine that requests the parent by root (
sendBatchRootRequest).Since #13061 that goroutine ran on
context.Background(), so it never observed beacon node shutdown, and a cancelled context was not honored mid-request either.This PR:
s.ctx) instead ofcontext.Background().context.AfterFunc(ctx, stream.Reset)inSendBeaconBlocksByRootRequestandSendExecutionPayloadEnvelopesByRootRequest, so cancellation interrupts a blocked response read instead of waiting for the next chunk deadline.ctx.Err()at the top of each retry and after each attempt insendBatchRootRequest, so a cancelled request returns immediately instead of burning the remainingnumOfTriesattempts.respTimeoutper attempt, the same boundsendBeaconBlocksRequestalready applies to the block request. Previously the envelope request inherited the caller's context with no timeout of its own.Which issue(s) does this PR fix?
N/A
Other notes for review
Acknowledgements