preserve monotonic weak-head weight - #17453
Draft
james-prysm wants to merge 1 commit into
Draft
Conversation
Count head-slot equivocators using justified effective balances only in weak-head checks. Keep ordinary fork-choice votes filtered, exclude proposer boost from the attestation score, and use the inclusive active-balance threshold. Capture committees from the supplied post-state during normal imports, expire snapshots outside the two-slot window, and keep lazy head-time lookup cache-only. Add regressions for equivocation, threshold boundaries, checkpoint refresh, cache eviction, retention, and no replay. Review caveat: recent nodes restored through InsertChain or startup without cached committee state conservatively remain strong for weak-head checks. This fallback avoids state replay under the fork-choice lock; eager snapshots cover normal imports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
Prysm removes equivocators from ordinary LMD vote accounting. The weak head predicate reused that filtered weight so detecting an equivocation could make a previously strong head become weak
Which issue(s) does this PR fix?
Fixes #
Other notes for review
Acknowledgements