Skip to content

Fix activation and exit queue ordering in GetValidatorQueue - #17442

Open
satushh wants to merge 2 commits into
developfrom
fix-validator-queue-sort
Open

Fix activation and exit queue ordering in GetValidatorQueue#17442
satushh wants to merge 2 commits into
developfrom
fix-validator-queue-sort

Conversation

@satushh

@satushh satushh commented Sep 2, 2026

Copy link
Copy Markdown
Member

What type of PR is this?

Bug fix

What does this PR do? Why is it needed?

  • The activation and exit queue sort comparators in the deprecated GetValidatorQueue gRPC handler indexed the full validator registry by queue position (vals[i]) instead of by the queued validator's index (vals[activationQ[i]]), so ActivationPublicKeys, ActivationValidatorIndices, ExitPublicKeys and ExitValidatorIndices were returned misordered whenever queue positions did not coincide with validator indices.
  • This fixes the comparators to sort through the queue slices and strengthens the existing tests with a validator outside the queue, which makes the ordering assertions fail against the old code.

Acknowledgements

  • I have read CONTRIBUTING.md.
  • I have included a uniquely named changelog fragment file.
  • I have added a description with sufficient context for reviewers to understand this PR.
  • I have tested that my changes work as expected and I added a testing plan to the PR description (if applicable).

@satushh
satushh marked this pull request as ready for review September 7, 2026 09:58
@satushh
satushh requested a review from a team as a code owner September 7, 2026 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants